[前][次][番号順一覧][スレッド一覧]

ruby-changes:66502

From: Nobuyoshi <ko1@a...>
Date: Thu, 17 Jun 2021 14:07:43 +0900 (JST)
Subject: [ruby-changes:66502] 95ef545997 (master): [rubygems/rubygems] Close then unlink tempfiles on Windows

https://git.ruby-lang.org/ruby.git/commit/?id=95ef545997

From 95ef5459978300e4a3bbbeb1bd6cd86d040db168 Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@r...>
Date: Thu, 17 Jun 2021 12:13:13 +0900
Subject: [rubygems/rubygems] Close then unlink tempfiles on Windows

In ruby/ruby test actions, number of "leaked tempfile" messages
are shown on Windows.

As Windows disallows removing open files, `Tempfile#unlink` fails
silently before `#close`.
Close then unlink by `#close!` instead.

https://github.com/rubygems/rubygems/commit/fe0b88ac30
---
 test/rubygems/helper.rb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/test/rubygems/helper.rb b/test/rubygems/helper.rb
index 2a37e38..9854263 100644
--- a/test/rubygems/helper.rb
+++ b/test/rubygems/helper.rb
@@ -153,15 +153,13 @@ class Gem::TestCase < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/helper.rb#L153
 
         return captured_stdout.read, captured_stderr.read
       ensure
-        captured_stdout.unlink
-        captured_stderr.unlink
         $stdout.reopen orig_stdout
         $stderr.reopen orig_stderr
 
         orig_stdout.close
         orig_stderr.close
-        captured_stdout.close
-        captured_stderr.close
+        captured_stdout.close!
+        captured_stderr.close!
       end
     end
   end
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]