ruby-changes:65534
From: Kazuki <ko1@a...>
Date: Tue, 16 Mar 2021 20:38:48 +0900 (JST)
Subject: [ruby-changes:65534] 10d360847b (master): [ruby/openssl] pkey: prefer PKey.read over PKey::RSA.new in docs
https://git.ruby-lang.org/ruby.git/commit/?id=10d360847b From 10d360847baf3394b7d9cd0dca6fa6908a2ce604 Mon Sep 17 00:00:00 2001 From: Kazuki Yamaguchi <k@r...> Date: Wed, 22 Mar 2017 03:51:24 +0900 Subject: [ruby/openssl] pkey: prefer PKey.read over PKey::RSA.new in docs https://github.com/ruby/openssl/commit/cf92a3ffba --- ext/openssl/ossl.c | 6 +++--- sample/openssl/echo_cli.rb | 2 +- sample/openssl/echo_svr.rb | 2 +- sample/openssl/gen_csr.rb | 2 +- sample/openssl/smime_read.rb | 2 +- sample/openssl/smime_write.rb | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ext/openssl/ossl.c b/ext/openssl/ossl.c index ce02efd..b9e5ba2 100644 --- a/ext/openssl/ossl.c +++ b/ext/openssl/ossl.c @@ -682,13 +682,13 @@ ossl_crypto_fixed_length_secure_compare(VALUE dummy, VALUE str1, VALUE str2) https://github.com/ruby/ruby/blob/trunk/ext/openssl/ossl.c#L682 * * A key can also be loaded from a file. * - * key2 = OpenSSL::PKey::RSA.new File.read 'private_key.pem' + * key2 = OpenSSL::PKey.read File.read 'private_key.pem' * key2.public? # => true * key2.private? # => true * * or * - * key3 = OpenSSL::PKey::RSA.new File.read 'public_key.pem' + * key3 = OpenSSL::PKey.read File.read 'public_key.pem' * key3.public? # => true * key3.private? # => false * @@ -700,7 +700,7 @@ ossl_crypto_fixed_length_secure_compare(VALUE dummy, VALUE str1, VALUE str2) https://github.com/ruby/ruby/blob/trunk/ext/openssl/ossl.c#L700 * * key4_pem = File.read 'private.secure.pem' * pass_phrase = 'my secure pass phrase goes here' - * key4 = OpenSSL::PKey::RSA.new key4_pem, pass_phrase + * key4 = OpenSSL::PKey.read key4_pem, pass_phrase * * == RSA Encryption * diff --git a/sample/openssl/echo_cli.rb b/sample/openssl/echo_cli.rb index 069a21e..3fbadf3 100644 --- a/sample/openssl/echo_cli.rb +++ b/sample/openssl/echo_cli.rb @@ -15,7 +15,7 @@ ca_path = options["C"] https://github.com/ruby/ruby/blob/trunk/sample/openssl/echo_cli.rb#L15 ctx = OpenSSL::SSL::SSLContext.new() if cert_file && key_file ctx.cert = OpenSSL::X509::Certificate.new(File::read(cert_file)) - ctx.key = OpenSSL::PKey::RSA.new(File::read(key_file)) + ctx.key = OpenSSL::PKey.read(File::read(key_file)) end if ca_path ctx.verify_mode = OpenSSL::SSL::VERIFY_PEER diff --git a/sample/openssl/echo_svr.rb b/sample/openssl/echo_svr.rb index ba15394..1cc07b9 100644 --- a/sample/openssl/echo_svr.rb +++ b/sample/openssl/echo_svr.rb @@ -13,7 +13,7 @@ ca_path = options["C"] https://github.com/ruby/ruby/blob/trunk/sample/openssl/echo_svr.rb#L13 if cert_file && key_file cert = OpenSSL::X509::Certificate.new(File::read(cert_file)) - key = OpenSSL::PKey::RSA.new(File::read(key_file)) + key = OpenSSL::PKey.read(File::read(key_file)) else key = OpenSSL::PKey::RSA.new(512){ print "." } puts diff --git a/sample/openssl/gen_csr.rb b/sample/openssl/gen_csr.rb index a061260..2602b68 100644 --- a/sample/openssl/gen_csr.rb +++ b/sample/openssl/gen_csr.rb @@ -25,7 +25,7 @@ name = X509::Name.parse(name_str) https://github.com/ruby/ruby/blob/trunk/sample/openssl/gen_csr.rb#L25 keypair = nil if keypair_file - keypair = PKey::RSA.new(File.open(keypair_file).read) + keypair = PKey.read(File.read(keypair_file)) else keypair = PKey::RSA.new(1024) { putc "." } puts diff --git a/sample/openssl/smime_read.rb b/sample/openssl/smime_read.rb index 17394f9..a70105f 100644 --- a/sample/openssl/smime_read.rb +++ b/sample/openssl/smime_read.rb @@ -11,7 +11,7 @@ ca_path = options["C"] https://github.com/ruby/ruby/blob/trunk/sample/openssl/smime_read.rb#L11 data = $stdin.read cert = X509::Certificate.new(File::read(cert_file)) -key = PKey::RSA.new(File::read(key_file)) +key = PKey::read(File::read(key_file)) p7enc = PKCS7::read_smime(data) data = p7enc.decrypt(key, cert) diff --git a/sample/openssl/smime_write.rb b/sample/openssl/smime_write.rb index 5a5236c..20c933b 100644 --- a/sample/openssl/smime_write.rb +++ b/sample/openssl/smime_write.rb @@ -9,7 +9,7 @@ key_file = options["k"] https://github.com/ruby/ruby/blob/trunk/sample/openssl/smime_write.rb#L9 rcpt_file = options["r"] cert = X509::Certificate.new(File::read(cert_file)) -key = PKey::RSA.new(File::read(key_file)) +key = PKey::read(File::read(key_file)) data = "Content-Type: text/plain\r\n" data << "\r\n" -- cgit v1.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/