[前][次][番号順一覧][スレッド一覧]

ruby-changes:65323

From: Takashi <ko1@a...>
Date: Tue, 23 Feb 2021 16:45:44 +0900 (JST)
Subject: [ruby-changes:65323] 95251dc8a9 (master): Drop check_branch CI job

https://git.ruby-lang.org/ruby.git/commit/?id=95251dc8a9

From 95251dc8a9dd76ab1117812f932e77c8230d5a13 Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Mon, 22 Feb 2021 23:38:44 -0800
Subject: Drop check_branch CI job

Now that GitHub Actions always skips any job if [ci skip] is given
regardless of our CI config, we cannot merge such PRs like https://github.com/ruby/ruby/pull/4211
unless you're an admin.
https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

To avoid letting us spend time to ask contributors to remove [ci skip]
before merging PRs, I removed the "check_branch" requirement from
protected branches.

Because the main purpose of this job was to prevent (non-admin)
committers from directly pushing commits to the GitHub mirror, this job
is now useless.
---
 .github/workflows/check_branch.yml | 22 ----------------------
 1 file changed, 22 deletions(-)
 delete mode 100644 .github/workflows/check_branch.yml

diff --git a/.github/workflows/check_branch.yml b/.github/workflows/check_branch.yml
deleted file mode 100644
index 37cf3a9..0000000
--- a/.github/workflows/check_branch.yml
+++ /dev/null
@@ -1,22 +0,0 @@ https://github.com/ruby/ruby/blob/trunk/#L0
-# We bidirectionally synchronize github.com/ruby/ruby.git's master branch and
-# git.ruby-lang.org/ruby.git's master branch.
-# We can use a pull request's merge button only on the master branch.
-#
-# Therefore, we require to pass this "check_branch" on all protected branches
-# to prevent us from accidentally pushing commits to GitHub directly.
-#
-# Details: https://bugs.ruby-lang.org/issues/16094
-name: Pull Request
-on: [pull_request]
-jobs:
-  check_branch:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check if branch is master
-        run: |
-          if [ "$BASE_REF" != master ]; then
-            echo "Only master branch accepts a pull request, but it's '$BASE_REF'."
-            exit 1
-          fi
-        env:
-          BASE_REF: ${{ github.base_ref }}
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]