ruby-changes:64425
From: =E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3 <ko1@a...>
Date: Tue, 22 Dec 2020 02:52:06 +0900 (JST)
Subject: [ruby-changes:64425] c30f03d328 (master): Data: delete
https://git.ruby-lang.org/ruby.git/commit/?id=c30f03d328 From c30f03d32833f38fedf41ecb08f1ade9c6657fef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= <shyouhei@r...> Date: Mon, 27 Jul 2020 16:15:28 +0900 Subject: Data: delete Has been deprecated since 684bdf6171b76f5bc5e4f05926a5ab01ec2b4fd5. Matz says in [ruby-core:83954] that Data should be an alias of Object. Because rb_cData has not been deprecated, let us deprecate the constant to make it a C-level synonym of rb_cObject. diff --git a/error.c b/error.c index ce3dc11..e74b214 100644 --- a/error.c +++ b/error.c @@ -2786,7 +2786,7 @@ Init_Exception(void) https://github.com/ruby/ruby/blob/trunk/error.c#L2786 rb_define_method(rb_eNameError, "name", name_err_name, 0); rb_define_method(rb_eNameError, "receiver", name_err_receiver, 0); rb_define_method(rb_eNameError, "local_variables", name_err_local_variables, 0); - rb_cNameErrorMesg = rb_define_class_under(rb_eNameError, "message", rb_cData); + rb_cNameErrorMesg = rb_define_class_under(rb_eNameError, "message", rb_cObject); rb_define_method(rb_cNameErrorMesg, "==", name_err_mesg_equal, 1); rb_define_method(rb_cNameErrorMesg, "to_str", name_err_mesg_to_str, 0); rb_define_method(rb_cNameErrorMesg, "_dump", name_err_mesg_dump, 1); diff --git a/include/ruby/internal/globals.h b/include/ruby/internal/globals.h index a697376..6b4e8fd 100644 --- a/include/ruby/internal/globals.h +++ b/include/ruby/internal/globals.h @@ -20,6 +20,7 @@ https://github.com/ruby/ruby/blob/trunk/include/ruby/internal/globals.h#L20 * extension libraries. They could be written in C++98. * @brief Ruby-level global variables / constants, visible from C. */ +#include "ruby/internal/attr/deprecated.h" #include "ruby/internal/attr/pure.h" #include "ruby/internal/dllexport.h" #include "ruby/internal/fl_type.h" @@ -48,6 +49,7 @@ RUBY_EXTERN VALUE rb_cArray; https://github.com/ruby/ruby/blob/trunk/include/ruby/internal/globals.h#L49 RUBY_EXTERN VALUE rb_cBinding; RUBY_EXTERN VALUE rb_cClass; RUBY_EXTERN VALUE rb_cCont; +RBIMPL_ATTR_DEPRECATED(("by: rb_cObject. Will be removed in 3.1.")) RUBY_EXTERN VALUE rb_cData; RUBY_EXTERN VALUE rb_cDir; RUBY_EXTERN VALUE rb_cEncoding; diff --git a/object.c b/object.c index 8626d5c..bf65254 100644 --- a/object.c +++ b/object.c @@ -32,6 +32,7 @@ https://github.com/ruby/ruby/blob/trunk/object.c#L32 #include "internal/struct.h" #include "internal/symbol.h" #include "internal/variable.h" +#include "internal/warnings.h" #include "probes.h" #include "ruby/encoding.h" #include "ruby/st.h" @@ -4330,6 +4331,25 @@ f_sprintf(int c, const VALUE *v, VALUE _) https://github.com/ruby/ruby/blob/trunk/object.c#L4331 return rb_f_sprintf(c, v); } +COMPILER_WARNING_PUSH +#if defined(_MSC_VER) +COMPILER_WARNING_IGNORED(4996) +#elif defined(__INTEL_COMPILER) +COMPILER_WARNING_IGNORED(1786) +#elif __has_warning("-Wdeprecated-declarations") +COMPILER_WARNING_IGNORED(-Wdeprecated-declarations) +#elif defined(__GNUC__) +COMPILER_WARNING_IGNORED(-Wdeprecated-declarations) +#endif + +static inline void +Init_rb_cData(void) +{ + rb_cData = rb_cObject; +} + +COMPILER_WARNING_POP + /* * Document-class: Class * @@ -4662,15 +4682,7 @@ InitVM_Object(void) https://github.com/ruby/ruby/blob/trunk/object.c#L4682 rb_undef_method(rb_cClass, "append_features"); rb_undef_method(rb_cClass, "prepend_features"); - /* - * Document-class: Data - * - * This is a deprecated class, base class for C extensions using - * Data_Make_Struct or Data_Wrap_Struct. - */ - rb_cData = rb_define_class("Data", rb_cObject); - rb_undef_alloc_func(rb_cData); - rb_deprecate_constant(rb_cObject, "Data"); + Init_rb_cData(); rb_cTrueClass = rb_define_class("TrueClass", rb_cObject); rb_cTrueClass_to_s = rb_fstring_enc_lit("true", rb_usascii_encoding()); diff --git a/spec/ruby/core/data/constants_spec.rb b/spec/ruby/core/data/constants_spec.rb index 0e47a82..5027ae0 100644 --- a/spec/ruby/core/data/constants_spec.rb +++ b/spec/ruby/core/data/constants_spec.rb @@ -1,13 +1,15 @@ https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/data/constants_spec.rb#L1 require_relative '../../spec_helper' -describe "Data" do - it "is a subclass of Object" do - suppress_warning do - Data.superclass.should == Object +ruby_version_is ''...'2.8' do + describe "Data" do + it "is a subclass of Object" do + suppress_warning do + Data.superclass.should == Object + end end - end - it "is deprecated" do - -> { Data }.should complain(/constant ::Data is deprecated/) + it "is deprecated" do + -> { Data }.should complain(/constant ::Data is deprecated/) + end end end diff --git a/transcode.c b/transcode.c index 5bae646..a72afdc 100644 --- a/transcode.c +++ b/transcode.c @@ -4462,7 +4462,7 @@ InitVM_transcode(void) https://github.com/ruby/ruby/blob/trunk/transcode.c#L4462 rb_define_method(rb_cString, "encode", str_encode, -1); rb_define_method(rb_cString, "encode!", str_encode_bang, -1); - rb_cEncodingConverter = rb_define_class_under(rb_cEncoding, "Converter", rb_cData); + rb_cEncodingConverter = rb_define_class_under(rb_cEncoding, "Converter", rb_cObject); rb_define_alloc_func(rb_cEncodingConverter, econv_s_allocate); rb_define_singleton_method(rb_cEncodingConverter, "asciicompat_encoding", econv_s_asciicompat_encoding, 1); rb_define_singleton_method(rb_cEncodingConverter, "search_convpath", econv_s_search_convpath, -1); -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/