ruby-changes:62556
From: Alan <ko1@a...>
Date: Wed, 12 Aug 2020 01:02:20 +0900 (JST)
Subject: [ruby-changes:62556] 7930a352a5 (master): Test out fix for OpenSSL test flakiness
https://git.ruby-lang.org/ruby.git/commit/?id=7930a352a5 From 7930a352a57c42205eaf064c4ae70c16c5f6ed99 Mon Sep 17 00:00:00 2001 From: Alan Wu <XrXr@u...> Date: Tue, 11 Aug 2020 03:13:53 -0400 Subject: Test out fix for OpenSSL test flakiness `OpenSSL::TestX509Store#test_verify` has been failing intermittently on CI about once a day: - http://ci.rvm.jp/results/trunk-random2@phosphorus-docker/3121244 - http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3117661 - http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3111684 According to the test: > OpenSSL uses time(2) while Time.now uses clock_gettime(CLOCK_REALTIME), > and there may be difference. This difference is could be the cause for the flaky failures. Let's see if giving the certificate more room solves the problem. In any case, I will revert this in a week. I think changes to these should go to https://github.com/ruby/openssl/? diff --git a/test/openssl/test_x509store.rb b/test/openssl/test_x509store.rb index b0b9523..1cbc73d 100644 --- a/test/openssl/test_x509store.rb +++ b/test/openssl/test_x509store.rb @@ -66,7 +66,7 @@ class OpenSSL::TestX509Store < OpenSSL::TestCase https://github.com/ruby/ruby/blob/trunk/test/openssl/test_x509store.rb#L66 ee1_cert = issue_cert(@ee1, @dsa256, 10, ee_exts, ca2_cert, @rsa1024) ee2_cert = issue_cert(@ee2, @dsa512, 20, ee_exts, ca2_cert, @rsa1024) ee3_cert = issue_cert(@ee2, @dsa512, 30, ee_exts, ca2_cert, @rsa1024, - not_before: now-100, not_after: now-1) + not_before: now-100, not_after: now-50) ee4_cert = issue_cert(@ee2, @dsa512, 40, ee_exts, ca2_cert, @rsa1024, not_before: now+1000, not_after: now+2000,) -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/