[前][次][番号順一覧][スレッド一覧]

ruby-changes:62484

From: David <ko1@a...>
Date: Fri, 31 Jul 2020 21:08:58 +0900 (JST)
Subject: [ruby-changes:62484] e6be06e4ef (master): [rubygems/rubygems] Fix some intermittent test failures on truffleruby

https://git.ruby-lang.org/ruby.git/commit/?id=e6be06e4ef

From e6be06e4ef260a1a96fddd47fd632d61875b8b85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Wed, 22 Jul 2020 18:44:59 +0200
Subject: [rubygems/rubygems] Fix some intermittent test failures on
 truffleruby

Since they changed their default to not generate documentation on `gem
install`, we're getting some intermittent test failures. Can be
reproduced with:

```
TRUFFLERUBYOPT="--experimental-options --testing-rubygems" TESTOPTS=--name="/^\(?:TestGemGemRunner#\(?:test_list_succeeds\)\|TestGemCommandsUpdateCommand#\(?:test_handle_options_system\)\)$/ --seed=54277 --verbose" rake
```

Fix it by resetting all permanent CLI options when CLI runner loads
configuration.

https://github.com/rubygems/rubygems/commit/7d896f4b74

diff --git a/test/rubygems/test_gem_gem_runner.rb b/test/rubygems/test_gem_gem_runner.rb
index a2b145e..72a5c83 100644
--- a/test/rubygems/test_gem_gem_runner.rb
+++ b/test/rubygems/test_gem_gem_runner.rb
@@ -8,6 +8,7 @@ class TestGemGemRunner < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_gem_runner.rb#L8
     require 'rubygems/command'
     @orig_args = Gem::Command.build_args
     @orig_specific_extra_args = Gem::Command.specific_extra_args_hash.dup
+    @orig_extra_args = Gem::Command.extra_args.dup
 
     require 'rubygems/gem_runner'
     @runner = Gem::GemRunner.new
@@ -18,6 +19,7 @@ class TestGemGemRunner < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_gem_runner.rb#L19
 
     Gem::Command.build_args = @orig_args
     Gem::Command.specific_extra_args_hash = @orig_specific_extra_args
+    Gem::Command.extra_args = @orig_extra_args
   end
 
   def test_do_configuration
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]