ruby-changes:62251
From: Utkarsh <ko1@a...>
Date: Wed, 15 Jul 2020 16:06:07 +0900 (JST)
Subject: [ruby-changes:62251] fd709382b6 (master): [rubygems/rubygems] Tag the specs with :readline
https://git.ruby-lang.org/ruby.git/commit/?id=fd709382b6 From fd709382b62ded5065941e75ed1c73e1df75a142 Mon Sep 17 00:00:00 2001 From: Utkarsh Gupta <utkarsh@d...> Date: Tue, 30 Jun 2020 23:30:19 +0530 Subject: [rubygems/rubygems] Tag the specs with :readline The newly added specs needs to be tagged as :readline, otherwise they fail on Windows with the backtrace: `ZeroDivisionError: divided by 0`. Such issues are already being skipped on Windows. Signed-off-by: Utkarsh Gupta <utkarsh@d...> https://github.com/rubygems/rubygems/commit/391f860af4 diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb index 39a69fe..7dca5f5 100644 --- a/spec/bundler/commands/newgem_spec.rb +++ b/spec/bundler/commands/newgem_spec.rb @@ -212,35 +212,35 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L212 end end - it "has no rubocop offenses when using --rubocop flag" do + it "has no rubocop offenses when using --rubocop flag", :readline do skip "ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec" if ruby_core? bundle "gem #{gem_name} --rubocop" bundle_exec_rubocop expect(err).to be_empty end - it "has no rubocop offenses when using --ext and --rubocop flag" do + it "has no rubocop offenses when using --ext and --rubocop flag", :readline do skip "ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec" if ruby_core? bundle "gem #{gem_name} --ext --rubocop" bundle_exec_rubocop expect(err).to be_empty end - it "has no rubocop offenses when using --ext, --test=minitest, and --rubocop flag" do + it "has no rubocop offenses when using --ext, --test=minitest, and --rubocop flag", :readline do skip "ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec" if ruby_core? bundle "gem #{gem_name} --ext --test=minitest --rubocop" bundle_exec_rubocop expect(err).to be_empty end - it "has no rubocop offenses when using --ext, --test=rspec, and --rubocop flag" do + it "has no rubocop offenses when using --ext, --test=rspec, and --rubocop flag", :readline do skip "ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec" if ruby_core? bundle "gem #{gem_name} --ext --test=rspec --rubocop" bundle_exec_rubocop expect(err).to be_empty end - it "has no rubocop offenses when using --ext, --ext=test-unit, and --rubocop flag" do + it "has no rubocop offenses when using --ext, --ext=test-unit, and --rubocop flag", :readline do skip "ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec" if ruby_core? bundle "gem #{gem_name} --ext --test=test-unit --rubocop" bundle_exec_rubocop -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/