ruby-changes:62065
From: =E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3 <ko1@a...>
Date: Mon, 29 Jun 2020 11:08:41 +0900 (JST)
Subject: [ruby-changes:62065] 3b8d9badab (master): rb_mod_const_get: do not goto into a branch
https://git.ruby-lang.org/ruby.git/commit/?id=3b8d9badab From 3b8d9badab0433e3022c2d423c3f53b00de634d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= <shyouhei@r...> Date: Tue, 16 Jun 2020 10:50:53 +0900 Subject: rb_mod_const_get: do not goto into a branch I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor. diff --git a/object.c b/object.c index 0c59985..6ecf760 100644 --- a/object.c +++ b/object.c @@ -2504,8 +2504,7 @@ rb_mod_const_get(int argc, VALUE *argv, VALUE mod) https://github.com/ruby/ruby/blob/trunk/object.c#L2504 pend = path + RSTRING_LEN(name); if (p >= pend || !*p) { - wrong_name: - rb_name_err_raise(wrong_constant_name, mod, name); + goto wrong_name; } if (p + 2 < pend && p[0] == ':' && p[1] == ':') { @@ -2572,6 +2571,9 @@ rb_mod_const_get(int argc, VALUE *argv, VALUE mod) https://github.com/ruby/ruby/blob/trunk/object.c#L2571 } return mod; + + wrong_name: + rb_name_err_raise(wrong_constant_name, mod, name); } /* -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/