ruby-changes:6176
From: shyouhei <ko1@a...>
Date: Sun, 29 Jun 2008 18:24:34 +0900 (JST)
Subject: [ruby-changes:6176] Ruby:r17688 (ruby_1_8_6): merge revision(s) 17570:
shyouhei 2008-06-29 18:24:21 +0900 (Sun, 29 Jun 2008) New Revision: 17688 Modified files: branches/ruby_1_8_6/ChangeLog branches/ruby_1_8_6/array.c branches/ruby_1_8_6/version.h Log: merge revision(s) 17570: * array.c (rb_ary_fill): not depend on unspecified behavior at integer overflow. reported by Vincenzo Iozzo <snagg AT openssl.it>. http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8_6/ChangeLog?r1=17688&r2=17687&diff_format=u http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8_6/version.h?r1=17688&r2=17687&diff_format=u http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8_6/array.c?r1=17688&r2=17687&diff_format=u Index: ruby_1_8_6/array.c =================================================================== --- ruby_1_8_6/array.c (revision 17687) +++ ruby_1_8_6/array.c (revision 17688) @@ -2272,10 +2272,10 @@ break; } rb_ary_modify(ary); - end = beg + len; - if (end < 0) { + if (len > ARY_MAX_SIZE - beg) { rb_raise(rb_eArgError, "argument too big"); } + end = beg + len; if (end > RARRAY(ary)->len) { if (end >= RARRAY(ary)->aux.capa) { REALLOC_N(RARRAY(ary)->ptr, VALUE, end); Index: ruby_1_8_6/ChangeLog =================================================================== --- ruby_1_8_6/ChangeLog (revision 17687) +++ ruby_1_8_6/ChangeLog (revision 17688) @@ -1,3 +1,8 @@ +Sun Jun 29 18:24:13 2008 Nobuyoshi Nakada <nobu@r...> + + * array.c (rb_ary_fill): not depend on unspecified behavior at integer + overflow. reported by Vincenzo Iozzo <snagg AT openssl.it>. + Sun Jun 29 18:21:23 2008 Masaki Suketa <masaki.suketa@n...> * ext/win32ole/win32ole.c(ole_invoke): fix memory leak. Index: ruby_1_8_6/version.h =================================================================== --- ruby_1_8_6/version.h (revision 17687) +++ ruby_1_8_6/version.h (revision 17688) @@ -2,7 +2,7 @@ #define RUBY_RELEASE_DATE "2008-06-29" #define RUBY_VERSION_CODE 186 #define RUBY_RELEASE_CODE 20080629 -#define RUBY_PATCHLEVEL 247 +#define RUBY_PATCHLEVEL 248 #define RUBY_VERSION_MAJOR 1 #define RUBY_VERSION_MINOR 8 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/