[前][次][番号順一覧][スレッド一覧]

ruby-changes:61703

From: Takashi <ko1@a...>
Date: Sun, 14 Jun 2020 08:34:09 +0900 (JST)
Subject: [ruby-changes:61703] 1583c743d5 (master): Skip test_getbinaryfile_command_injection on --jit-wait

https://git.ruby-lang.org/ruby.git/commit/?id=1583c743d5

From 1583c743d52a0ba94c98c2723b9e595b5e400c6e Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Sat, 13 Jun 2020 16:32:29 -0700
Subject: Skip test_getbinaryfile_command_injection on --jit-wait

Timeout-based test often fails with --jit-wait as a false positive.
Like other tests in the TestFTP, let me skip this as well.

http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3001181
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3000134
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2999923
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2998857

diff --git a/test/net/ftp/test_ftp.rb b/test/net/ftp/test_ftp.rb
index 0bc45f2..571338f 100644
--- a/test/net/ftp/test_ftp.rb
+++ b/test/net/ftp/test_ftp.rb
@@ -2243,6 +2243,8 @@ EOF https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L2243
   end
 
   def test_getbinaryfile_command_injection
+    # http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3001181
+    skip 'This has been too unstable with --jit-wait' if defined?(RubyVM::MJIT) && RubyVM::MJIT.enabled?
     skip "| is not allowed in filename on Windows" if windows?
     [false, true].each do |resume|
       commands = []
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]