[前][次][番号順一覧][スレッド一覧]

ruby-changes:61559

From: David <ko1@a...>
Date: Fri, 5 Jun 2020 07:34:41 +0900 (JST)
Subject: [ruby-changes:61559] 8739bc449f (master): [rubygems/rubygems] Only run optional validations in packaging contexts

https://git.ruby-lang.org/ruby.git/commit/?id=8739bc449f

From 8739bc449f7f560fe0c5addf7da2e73f4537b0cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Fri, 29 May 2020 16:31:25 +0200
Subject: [rubygems/rubygems] Only run optional validations in packaging
 contexts

https://github.com/rubygems/rubygems/commit/f4fe949dfa

diff --git a/lib/rubygems/specification_policy.rb b/lib/rubygems/specification_policy.rb
index f96e95b..3a3dba9 100644
--- a/lib/rubygems/specification_policy.rb
+++ b/lib/rubygems/specification_policy.rb
@@ -44,7 +44,7 @@ class Gem::SpecificationPolicy https://github.com/ruby/ruby/blob/trunk/lib/rubygems/specification_policy.rb#L44
   def validate(strict = false)
     validate_required!
 
-    validate_optional(strict)
+    validate_optional(strict) if packaging || strict
 
     true
   end
diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb
index e223171..d0f11bf 100644
--- a/test/rubygems/test_gem_specification.rb
+++ b/test/rubygems/test_gem_specification.rb
@@ -3141,6 +3141,17 @@ http://spdx.org/licenses or 'Nonstandard' for a nonstandard license. https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_specification.rb#L3141
     WARNING
   end
 
+  def test_validate_license_in_a_non_packaging_context
+    util_setup_validate
+
+    use_ui @ui do
+      @a1.licenses.clear
+      @a1.validate(false)
+    end
+
+    assert_empty @ui.error
+  end
+
   def test_removed_methods
     assert_equal Gem::Specification::REMOVED_METHODS, [:rubyforge_project=]
   end
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]