[前][次][番号順一覧][スレッド一覧]

ruby-changes:61548

From: Benoit <ko1@a...>
Date: Fri, 5 Jun 2020 07:34:30 +0900 (JST)
Subject: [ruby-changes:61548] 345461018d (master): [rubygems/rubygems] Relax test to still check we're calling the expected Ruby

https://git.ruby-lang.org/ruby.git/commit/?id=345461018d

From 345461018da1ba5a6aa5b14762e7d8d159f864c1 Mon Sep 17 00:00:00 2001
From: Benoit Daloze <eregontp@g...>
Date: Wed, 22 Apr 2020 22:17:50 +0200
Subject: [rubygems/rubygems] Relax test to still check we're calling the
 expected Ruby

* But not enforce that error looks like
  /full/path/to/ruby/bin/ruby: No such file or directory
  but instead allow
  truffleruby: No such file or directory

A typical output for gem_make.out looks like:
current directory: /.../rubygems/tmp/test_rubygems_112388/gemhome/gems/a-2
/.../ruby-2.6.6/bin/ruby -I /.../rubygems/lib -r ./siteconf20200422-112388-nyrcy0.rb extconf.rb ''
/.../ruby-2.6.6/bin/ruby: No such file or directory -- extconf.rb (LoadError)

https://github.com/rubygems/rubygems/commit/e6e08882cc

diff --git a/test/rubygems/test_gem_ext_builder.rb b/test/rubygems/test_gem_ext_builder.rb
index 5727077..d690569 100644
--- a/test/rubygems/test_gem_ext_builder.rb
+++ b/test/rubygems/test_gem_ext_builder.rb
@@ -233,15 +233,11 @@ install: https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_ext_builder.rb#L233
     gem_make_out = File.join @spec.extension_dir, 'gem_make.out'
     cmd_make_out = File.read(gem_make_out)
 
-    assert_match %r{#{Regexp.escape Gem.ruby}.* extconf\.rb}, cmd_make_out
+    assert_match %r{#{Regexp.escape Gem.ruby} .* extconf\.rb}, cmd_make_out
     assert_match %r{: No such file}, cmd_make_out
 
     refute_path_exists @spec.gem_build_complete_path
 
-    skip "Gem.ruby is not the name of the binary being run in the end" \
-      unless cmd_make_out.include? "#{Gem.ruby}:"
-
-    assert_match %r{#{Regexp.escape Gem.ruby}: No such file}, cmd_make_out
     assert_equal cwd, Dir.pwd
   end
 
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]