[前][次][番号順一覧][スレッド一覧]

ruby-changes:61526

From: David <ko1@a...>
Date: Fri, 5 Jun 2020 07:34:01 +0900 (JST)
Subject: [ruby-changes:61526] 3660d14de6 (master): [rubygems/rubygems] Make `rake package` log messages to stdout by default

https://git.ruby-lang.org/ruby.git/commit/?id=3660d14de6

From 3660d14de60ac4a2b420601db5b16c104a0c7858 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Sat, 16 May 2020 14:45:08 +0200
Subject: [rubygems/rubygems] Make `rake package` log messages to stdout by
 default

The logging to $stderr is only happening due to a bug in `FileUtils`.
Logging messages are not errors.

https://github.com/rubygems/rubygems/commit/4d1b6659e6

diff --git a/lib/rubygems/package_task.rb b/lib/rubygems/package_task.rb
index a11d09f..b355c2b 100644
--- a/lib/rubygems/package_task.rb
+++ b/lib/rubygems/package_task.rb
@@ -88,6 +88,7 @@ class Gem::PackageTask < Rake::PackageTask https://github.com/ruby/ruby/blob/trunk/lib/rubygems/package_task.rb#L88
     super gem.full_name, :noversion
     @gem_spec = gem
     @package_files += gem_spec.files if gem_spec.files
+    @fileutils_output = $stdout
   end
 
   ##
diff --git a/test/rubygems/test_gem_package_task.rb b/test/rubygems/test_gem_package_task.rb
index 56d574d..9d87db8 100644
--- a/test/rubygems/test_gem_package_task.rb
+++ b/test/rubygems/test_gem_package_task.rb
@@ -47,6 +47,34 @@ class TestGemPackageTask < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_package_task.rb#L47
     end
   end
 
+  def test_gem_package_prints_to_stdout_by_default
+    gem = Gem::Specification.new do |g|
+      g.name = "pkgr"
+      g.version = "1.2.3"
+
+      g.authors = %w[author]
+      g.files = %w[x]
+      g.summary = 'summary'
+    end
+
+    pkg = Gem::PackageTask.new(gem) do |p|
+      p.package_files << "y"
+    end
+
+    assert_equal %w[x y], pkg.package_files
+
+    Dir.chdir @tempdir do
+      FileUtils.touch 'x'
+      FileUtils.touch 'y'
+
+      _, err = capture_io do
+        Rake.application['package'].invoke
+      end
+
+      assert_empty err
+    end
+  end
+
   def test_gem_package_with_current_platform
     RakeFileUtils.verbose_flag = false
 
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]