ruby-changes:61497
From: David <ko1@a...>
Date: Fri, 5 Jun 2020 07:33:27 +0900 (JST)
Subject: [ruby-changes:61497] 5989827dc7 (master): [rubygems/rubygems] Improve wording of some specs
https://git.ruby-lang.org/ruby.git/commit/?id=5989827dc7 From 5989827dc7e39f882b61c1650c87d14599d21033 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...> Date: Thu, 28 May 2020 21:10:08 +0200 Subject: [rubygems/rubygems] Improve wording of some specs https://github.com/rubygems/rubygems/commit/3372b21553 diff --git a/spec/bundler/install/gemfile/groups_spec.rb b/spec/bundler/install/gemfile/groups_spec.rb index 27d9ffc..5656575 100644 --- a/spec/bundler/install/gemfile/groups_spec.rb +++ b/spec/bundler/install/gemfile/groups_spec.rb @@ -157,19 +157,19 @@ RSpec.describe "bundle install with groups" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/install/gemfile/groups_spec.rb#L157 expect(the_bundle).not_to include_gems "thin 1.0" end - it "does install gems from the optional group when requested" do + it "installs gems from the optional group when requested" do bundle :install, forgotten_command_line_options(:with => "debugging") expect(the_bundle).to include_gems "thin 1.0" end - it "does install gems from the previously requested group" do + it "installs gems from the previously requested group" do bundle :install, forgotten_command_line_options(:with => "debugging") expect(the_bundle).to include_gems "thin 1.0" bundle :install expect(the_bundle).to include_gems "thin 1.0" end - it "does install gems from the optional groups requested with BUNDLE_WITH" do + it "installs gems from the optional groups requested with BUNDLE_WITH" do ENV["BUNDLE_WITH"] = "debugging" bundle :install expect(the_bundle).to include_gems "thin 1.0" @@ -182,13 +182,13 @@ RSpec.describe "bundle install with groups" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/install/gemfile/groups_spec.rb#L182 expect(the_bundle).not_to include_gems "thin 1.0" end - it "does remove groups from without when passed at --with", :bundler => "< 3" do + it "removes groups from without when passed at --with", :bundler => "< 3" do bundle :install, forgotten_command_line_options(:without => "emo") bundle :install, forgotten_command_line_options(:with => "emo") expect(the_bundle).to include_gems "activesupport 2.3.5" end - it "does remove groups from with when passed at --without", :bundler => "< 3" do + it "removes groups from with when passed at --without", :bundler => "< 3" do bundle :install, forgotten_command_line_options(:with => "debugging") bundle :install, forgotten_command_line_options(:without => "debugging") expect(the_bundle).not_to include_gem "thin 1.0" @@ -219,12 +219,12 @@ RSpec.describe "bundle install with groups" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/install/gemfile/groups_spec.rb#L219 expect(the_bundle).not_to include_gems "activesupport 2.3.5" end - it "does have no effect when listing a not optional group in with" do + it "has no effect when listing a not optional group in with" do bundle :install, forgotten_command_line_options(:with => "emo") expect(the_bundle).to include_gems "activesupport 2.3.5" end - it "does have no effect when listing an optional group in without" do + it "has no effect when listing an optional group in without" do bundle :install, forgotten_command_line_options(:without => "debugging") expect(the_bundle).not_to include_gems "thin 1.0" end -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/