[前][次][番号順一覧][スレッド一覧]

ruby-changes:61491

From: David <ko1@a...>
Date: Fri, 5 Jun 2020 07:33:21 +0900 (JST)
Subject: [ruby-changes:61491] 5a12fc7c7f (master): [rubygems/rubygems] Unskip "monorepo issues"

https://git.ruby-lang.org/ruby.git/commit/?id=5a12fc7c7f

From 5a12fc7c7f55780433ceb404d9e7189099399b38 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Fri, 22 May 2020 11:51:14 +0200
Subject: [rubygems/rubygems] Unskip "monorepo issues"

They seem to be passing?

https://github.com/rubygems/rubygems/commit/a00d1e6896

diff --git a/spec/bundler/install/deploy_spec.rb b/spec/bundler/install/deploy_spec.rb
index 9563d32..9a5c505 100644
--- a/spec/bundler/install/deploy_spec.rb
+++ b/spec/bundler/install/deploy_spec.rb
@@ -333,8 +333,6 @@ RSpec.describe "install with --deployment or --frozen" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/install/deploy_spec.rb#L333
     end
 
     it "explodes if you unpin a source" do
-      skip "some of monorepo issues" if Gem.win_platform?
-
       build_git "rack"
 
       install_gemfile <<-G
@@ -355,8 +353,6 @@ RSpec.describe "install with --deployment or --frozen" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/install/deploy_spec.rb#L353
     end
 
     it "explodes if you unpin a source, leaving it pinned somewhere else" do
-      skip "some of monorepo issues" if Gem.win_platform?
-
       build_lib "foo", :path => lib_path("rack/foo")
       build_git "rack", :path => lib_path("rack")
 
diff --git a/spec/bundler/update/git_spec.rb b/spec/bundler/update/git_spec.rb
index 71f0e84..2233682 100644
--- a/spec/bundler/update/git_spec.rb
+++ b/spec/bundler/update/git_spec.rb
@@ -75,8 +75,6 @@ RSpec.describe "bundle update" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/update/git_spec.rb#L75
     end
 
     it "notices when you change the repo url in the Gemfile" do
-      skip "some of monorepo issues" if Gem.win_platform?
-
       build_git "foo", :path => lib_path("foo_one")
       build_git "foo", :path => lib_path("foo_two")
 
@@ -183,8 +181,6 @@ RSpec.describe "bundle update" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/update/git_spec.rb#L181
     end
 
     it "errors with a message when the .git repo is gone" do
-      skip "some of monorepo issues" if Gem.win_platform?
-
       build_git "foo", "1.0"
 
       install_gemfile <<-G
@@ -216,8 +212,6 @@ RSpec.describe "bundle update" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/update/git_spec.rb#L212
     end
 
     it "shows the previous version of the gem" do
-      skip "some of monorepo issues" if Gem.win_platform?
-
       build_git "rails", "2.3.2", :path => lib_path("rails")
 
       install_gemfile <<-G
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]