[前][次][番号順一覧][スレッド一覧]

ruby-changes:61146

From: David <ko1@a...>
Date: Fri, 8 May 2020 14:15:06 +0900 (JST)
Subject: [ruby-changes:61146] 6438c5848d (master): [rubygems/rubygems] Remove misleading comments

https://git.ruby-lang.org/ruby.git/commit/?id=6438c5848d

From 6438c5848d1f663ecd135903a2a323d6d6006838 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Sat, 21 Dec 2019 19:55:20 +0100
Subject: [rubygems/rubygems] Remove misleading comments

`site_dir`, or `vendor_dir`, is the location where the default version
of bundler & rubygems gets installed. These folders are placed directly
in the LOAD_PATH, so they cannot hold any nested gem directory
structure. So a single copy of either rubygems or bundler can be placed
in these folders.

What the tests are actually testing is the TODO comment that I'm
removing: that installing the default copy of bundler doesn't affect any
already installed copies of bundler as regular gems.

https://github.com/rubygems/rubygems/commit/7ca8831d72

diff --git a/test/rubygems/test_gem_commands_setup_command.rb b/test/rubygems/test_gem_commands_setup_command.rb
index f7d738a..7d33c0c 100644
--- a/test/rubygems/test_gem_commands_setup_command.rb
+++ b/test/rubygems/test_gem_commands_setup_command.rb
@@ -254,15 +254,8 @@ class TestGemCommandsSetupCommand < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_setup_command.rb#L254
     # expect to remove normal gem that was same version. because it's promoted default gems.
     refute_path_exists File.join(Gem.default_dir, "specifications", "bundler-#{BUNDLER_VERS}.gemspec")
 
-    # expect to install default gems. It location was `site_ruby` directory on real world.
     assert_path_exists "default/gems/bundler-#{BUNDLER_VERS}"
-
-    # expect to not remove other versions of bundler on `site_ruby`
     assert_path_exists 'default/gems/bundler-1.15.4'
-
-    # TODO: We need to assert to remove same version of bundler on gem_dir directory(It's not site_ruby dir)
-
-    # expect to not remove bundler-* directory.
     assert_path_exists 'default/gems/bundler-audit-1.0.0'
   end
 
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]