ruby-changes:61124
From: David <ko1@a...>
Date: Fri, 8 May 2020 14:14:45 +0900 (JST)
Subject: [ruby-changes:61124] b5a0db8be0 (master): [rubygems/rubygems] Remove unnecessary code from remote fetcher tests
https://git.ruby-lang.org/ruby.git/commit/?id=b5a0db8be0 From b5a0db8be0086f2d245fd77fd48f89e359d71312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...> Date: Fri, 27 Mar 2020 12:18:35 +0100 Subject: [rubygems/rubygems] Remove unnecessary code from remote fetcher tests This code is not necessary and has the bad side effect of causing test failures in cascade once a single test inside the file fails. See https://github.com/rubygems/rubygems/runs/538978838 for an example. https://github.com/rubygems/rubygems/commit/2291d32915 diff --git a/test/rubygems/test_gem_remote_fetcher.rb b/test/rubygems/test_gem_remote_fetcher.rb index c72bffb..c8c3c2f 100644 --- a/test/rubygems/test_gem_remote_fetcher.rb +++ b/test/rubygems/test_gem_remote_fetcher.rb @@ -108,10 +108,7 @@ PeIQQkFng2VVot/WAQbv3ePqWq07g1BBcwIBAg== https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_remote_fetcher.rb#L108 @server_uri = base_server_uri + "/yaml" @server_z_uri = base_server_uri + "/yaml.Z" - # REFACTOR: copied from test_gem_dependency_installer.rb - @gems_dir = File.join @tempdir, 'gems' @cache_dir = File.join @gemhome, "cache" - FileUtils.mkdir @gems_dir # TODO: why does the remote fetcher need it written to disk? @a1, @a1_gem = util_gem 'a', '1' do |s| -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/