[前][次][番号順一覧][スレッド一覧]

ruby-changes:60761

From: =E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3 <ko1@a...>
Date: Mon, 13 Apr 2020 16:39:56 +0900 (JST)
Subject: [ruby-changes:60761] 5dc6080cb8 (master): delete CACHELINE

https://git.ruby-lang.org/ruby.git/commit/?id=5dc6080cb8

From 5dc6080cb8bebdc7109bd6048e28aee656c3bb4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?=
 <shyouhei@r...>
Date: Mon, 13 Apr 2020 16:38:22 +0900
Subject: delete CACHELINE

Since https://github.com/ruby/ruby/pull/2888 this macro is no longer
used in any place.

diff --git a/internal/vm.h b/internal/vm.h
index 1c76913..6bd4500 100644
--- a/internal/vm.h
+++ b/internal/vm.h
@@ -23,17 +23,6 @@ https://github.com/ruby/ruby/blob/trunk/internal/vm.h#L23
 # undef rb_method_basic_definition_p
 #endif
 
-/* I have several reasons to choose 64 here:
- *
- * - A cache line must be a power-of-two size.
- * - Setting this to anything less than or equal to 32 boosts nothing.
- * - I have never seen an architecture that has 128 byte L1 cache line.
- * - I know Intel Core and Sparc T4 at least uses 64.
- * - I know jemalloc internally has this exact same `#define CACHE_LINE 64`.
- *   https://github.com/jemalloc/jemalloc/blob/dev/include/jemalloc/internal/jemalloc_internal_types.h
- */
-#define CACHELINE 64
-
 struct rb_callable_method_entry_struct; /* in method.h */
 struct rb_method_definition_struct;     /* in method.h */
 struct rb_execution_context_struct;     /* in vm_core.h */
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]