[前][次][番号順一覧][スレッド一覧]

ruby-changes:60093

From: Yusuke <ko1@a...>
Date: Sun, 16 Feb 2020 22:17:11 +0900 (JST)
Subject: [ruby-changes:60093] 331755c5e9 (master): Revert "test/openssl/test_ts.rb: tentatively skip a failing test on CentOS 6.9"

https://git.ruby-lang.org/ruby.git/commit/?id=331755c5e9

From 331755c5e97ff1a5c0a4a3ceed9c26ea2c580768 Mon Sep 17 00:00:00 2001
From: Yusuke Endoh <mame@r...>
Date: Sun, 16 Feb 2020 22:16:22 +0900
Subject: Revert "test/openssl/test_ts.rb: tentatively skip a failing test on
 CentOS 6.9"

This reverts commit a6d007c70b3aa5b55c9ca774446130356bd36eac.

Unfortunately, the test fails on armv7l
https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20200216T091708Z.fail.html.gz

diff --git a/test/openssl/test_ts.rb b/test/openssl/test_ts.rb
index 9af5022..c57f08c 100644
--- a/test/openssl/test_ts.rb
+++ b/test/openssl/test_ts.rb
@@ -67,17 +67,15 @@ _end_of_pem_ https://github.com/ruby/ruby/blob/trunk/test/openssl/test_ts.rb#L67
     @ts_cert_ee ||= OpenSSL::Certs.ts_cert_ee(ee_key, intermediate_cert, intermediate_key)
   end
 
-  # Tentatively, skip this test to make CentOS 6.9 CI green.
-  # After it become green, I'll remove CentOS 6.9 + ruby master from CI matrix
-  #def test_create_request
-  #  req = OpenSSL::Timestamp::Request.new
-  #  assert_equal(true, req.cert_requested?)
-  #  assert_equal(1, req.version)
-  #  assert_nil(req.algorithm)
-  #  assert_equal("", req.message_imprint)
-  #  assert_nil(req.policy_id)
-  #  assert_nil(req.nonce)
-  #end
+  def test_create_request
+    req = OpenSSL::Timestamp::Request.new
+    assert_equal(true, req.cert_requested?)
+    assert_equal(1, req.version)
+    assert_nil(req.algorithm)
+    assert_equal("", req.message_imprint)
+    assert_nil(req.policy_id)
+    assert_nil(req.nonce)
+  end
 
   def test_request_mandatory_fields
     req = OpenSSL::Timestamp::Request.new
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]