[前][次][番号順一覧][スレッド一覧]

ruby-changes:59957

From: Bernhard <ko1@a...>
Date: Sat, 8 Feb 2020 09:57:37 +0900 (JST)
Subject: [ruby-changes:59957] 07c98537ca (master): Clarified documentation in rb_integer_unpack [ci skip]

https://git.ruby-lang.org/ruby.git/commit/?id=07c98537ca

From 07c98537cae5c88cff0496fb8ef985771218fe1f Mon Sep 17 00:00:00 2001
From: "Bernhard F. Brodowsky" <bernhard.brodowsky@g...>
Date: Fri, 7 Feb 2020 19:57:15 -0500
Subject: Clarified documentation in rb_integer_unpack [ci skip]

I struggled figuring out which of the pack/unpack functions goes into which direction and the two first sentences were of the documentation were:
* Import an integer into a buffer.
* Export an integer into a buffer.

It sounds like both of them go from a ruby integer to a buffer because both use "into". So I fixed it and went to "Import an integer from a buffer". I find this much more clear.

diff --git a/bignum.c b/bignum.c
index 78c5681..e9bb578 100644
--- a/bignum.c
+++ b/bignum.c
@@ -3611,7 +3611,7 @@ rb_integer_pack(VALUE val, void *words, size_t numwords, size_t wordsize, size_t https://github.com/ruby/ruby/blob/trunk/bignum.c#L3611
 }
 
 /*
- * Import an integer into a buffer.
+ * Import an integer from a buffer.
  *
  * [words] buffer to import.
  * [numwords] the size of given buffer as number of words.
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]