ruby-changes:58580
From: Nobuyoshi <ko1@a...>
Date: Tue, 5 Nov 2019 17:42:53 +0900 (JST)
Subject: [ruby-changes:58580] 19f91f7880 (master): `DottedFormatter#finish` consistency
https://git.ruby-lang.org/ruby.git/commit/?id=19f91f7880 From 19f91f788016ef98e30ead047e53edeb7a5f2566 Mon Sep 17 00:00:00 2001 From: Nobuyoshi Nakada <nobu@r...> Date: Tue, 5 Nov 2019 15:50:28 +0900 Subject: `DottedFormatter#finish` consistency Rmoved optional parameter `printed_exceptions`, and clear `exceptions` just after printing each exception, instead. diff --git a/spec/mspec/lib/mspec/runner/formatters/multi.rb b/spec/mspec/lib/mspec/runner/formatters/multi.rb index 5932eee..085f961 100644 --- a/spec/mspec/lib/mspec/runner/formatters/multi.rb +++ b/spec/mspec/lib/mspec/runner/formatters/multi.rb @@ -33,8 +33,4 @@ class MultiFormatter < SpinnerFormatter https://github.com/ruby/ruby/blob/trunk/spec/mspec/lib/mspec/runner/formatters/multi.rb#L33 def print_exception(exc, count) print "\n#{count})\n#{exc}\n" end - - def finish - super(false) - end end diff --git a/spec/mspec/lib/mspec/runner/formatters/spinner.rb b/spec/mspec/lib/mspec/runner/formatters/spinner.rb index 89791b6..f9101ae 100644 --- a/spec/mspec/lib/mspec/runner/formatters/spinner.rb +++ b/spec/mspec/lib/mspec/runner/formatters/spinner.rb @@ -102,16 +102,11 @@ class SpinnerFormatter < DottedFormatter https://github.com/ruby/ruby/blob/trunk/spec/mspec/lib/mspec/runner/formatters/spinner.rb#L102 clear_progress_line print_exception(exception, @count) + exceptions.clear end # Callback for the MSpec :after event. Updates the spinner. def after(state = nil) print progress_line end - - def finish(printed_exceptions = true) - # We already printed the exceptions - @exceptions = [] if printed_exceptions - super() - end end -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/