ruby-changes:58012
From: Benoit <ko1@a...>
Date: Sun, 29 Sep 2019 20:58:17 +0900 (JST)
Subject: [ruby-changes:58012] e3b11566bf (master): Remove continue-on-error for test-bundled-gems
https://git.ruby-lang.org/ruby.git/commit/?id=e3b11566bf From e3b11566bfbb6ddcdd9f3483a6bdeb501a610fa9 Mon Sep 17 00:00:00 2001 From: Benoit Daloze <eregontp@g...> Date: Sat, 28 Sep 2019 11:45:23 +0200 Subject: Remove continue-on-error for test-bundled-gems * Otherwise, it takes a very long time to notice those tests broke. diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index de05e21..6911f87 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -46,13 +46,11 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/macos.yml#L46 env: MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies if: matrix.test_task != 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - # test-bundled-gems is separated for marking `continue-on-error` because it randomly fails. - name: Tests (test-bundled-gems) # Remove TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest if https://github.com/seattlerb/minitest/pull/798 resolved run: make -s ${{ matrix.test_task }} TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest env: RUBY_TESTOPTS: "-q --tty=no" - continue-on-error: true if: matrix.test_task == 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - name: Leaked Globals run: make -s leaked-globals diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 7e860dc..71fbdf2 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -74,13 +74,11 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/ubuntu.yml#L74 env: MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies if: matrix.test_task != 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - # test-bundled-gems is separated for marking `continue-on-error` because it randomly fails. - name: Tests (test-bundled-gems) # Remove TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest if https://github.com/seattlerb/minitest/pull/798 resolved run: make -s ${{ matrix.test_task }} TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest env: RUBY_TESTOPTS: "-q --tty=no" - continue-on-error: true if: matrix.test_task == 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - name: Leaked Globals run: make -s leaked-globals -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/