[前][次][番号順一覧][スレッド一覧]

ruby-changes:57858

From: Kazuhiro <ko1@a...>
Date: Sun, 22 Sep 2019 10:13:25 +0900 (JST)
Subject: [ruby-changes:57858] a0ce0b6297 (master): Add `if: always()` because 2.4.x's `make check` failed on snapshot [ci skip]

https://git.ruby-lang.org/ruby.git/commit/?id=a0ce0b6297

From a0ce0b6297852f64f6a05593e1364619da7a831d Mon Sep 17 00:00:00 2001
From: Kazuhiro NISHIYAMA <zn@m...>
Date: Sun, 22 Sep 2019 10:11:06 +0900
Subject: Add `if: always()` because 2.4.x's `make check` failed on snapshot
 [ci skip]

`check-snapshot-ruby_2_4` uses `make test` instead of `make check`.
https://github.com/ruby/actions/blob/95692e54f4263501db1508d51c1fb67c03b4f575/.github/workflows/snapshot.yml#L448-L449

`draft-release` use `make check` to make it simple, and
actions is required regardless of success or failure.

On the other hand, snapshot success can be ignored,
so normally it should not fail.

diff --git a/.github/workflows/draft-release.yml b/.github/workflows/draft-release.yml
index b76de55..cc82e80 100644
--- a/.github/workflows/draft-release.yml
+++ b/.github/workflows/draft-release.yml
@@ -129,8 +129,10 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/draft-release.yml#L129
         run: cd ruby-*/ && make $JOBS check TESTOPTS="-q --tty=no" MSPECOPT="-ff"
       - name: make install
         run: cd ruby-*/ && sudo make $JOBS install
+        if: always() # `make check` may fail when 2.4.x
       - name: ruby -v
         run: ruby -v
+        if: always() # `make check` may fail when 2.4.x
       - uses: k0kubun/action-slack@v...
         with:
           payload: |
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]