[前][次][番号順一覧][スレッド一覧]

ruby-changes:57518

From: Takashi <ko1@a...>
Date: Tue, 3 Sep 2019 21:39:40 +0900 (JST)
Subject: [ruby-changes:57518] ecc37ee67b (master): Stop testing inexistent instructions

https://git.ruby-lang.org/ruby.git/commit/?id=ecc37ee67b

From ecc37ee67b90426198bd768d0bf036663e301d06 Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Tue, 3 Sep 2019 21:38:32 +0900
Subject: Stop testing inexistent instructions


diff --git a/test/ruby/test_jit.rb b/test/ruby/test_jit.rb
index 1c1a07c..dbd48df 100644
--- a/test/ruby/test_jit.rb
+++ b/test/ruby/test_jit.rb
@@ -20,15 +20,11 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L20
     # not supported yet
     :defineclass,
     :opt_call_c_function,
-
-    # joke
-    :bitblt,
-    :answer,
-
-    # TODO: write tests for them
-    :reput,
-    :tracecoverage,
-  ]
+  ].each do |insn|
+    if !RubyVM::INSTRUCTION_NAMES.include?(insn.to_s)
+      warn "instruction #{insn.inspect} is not defined but included in TestJIT::TEST_PENDING_INSNS"
+    end
+  end
 
   def self.untested_insns
     @untested_insns ||= (RubyVM::INSTRUCTION_NAMES.map(&:to_sym) - TEST_PENDING_INSNS)
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]