[前][次][番号順一覧][スレッド一覧]

ruby-changes:57348

From: Kazuhiro <ko1@a...>
Date: Wed, 28 Aug 2019 09:27:32 +0900 (JST)
Subject: [ruby-changes:57348] Kazuhiro NISHIYAMA: 17c0ce3798 (master): Remove GITHUB_SHA from jobs.<job_id>.steps.env

https://git.ruby-lang.org/ruby.git/commit/?id=17c0ce3798

From 17c0ce379877fa3f8f79e84c5652bc2b74b9e08e Mon Sep 17 00:00:00 2001
From: Kazuhiro NISHIYAMA <zn@m...>
Date: Wed, 28 Aug 2019 09:20:07 +0900
Subject: Remove GITHUB_SHA from jobs.<job_id>.steps.env

because default value overrides it.
https://help.github.com/en/articles/virtual-environments-for-github-actions#environment-variables

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index dafc734..f299804 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -20,8 +20,6 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/coverage.yml#L20
       # Not using official actions/checkout because it's unstable and sometimes doesn't work for a fork.
       - name: Checkout ruby/ruby
         run: git clone --depth=10 https://github.com/ruby/ruby . && git reset --hard "$GITHUB_SHA"
-        env:
-          GITHUB_SHA: ${{ github.sha }}
         if: github.event_name == 'schedule'
       - name: Checkout a pull request
         run: git clone --depth=10 "--branch=$GITHUB_BRANCH" "https://github.com/${GITHUB_REPO}" . && git reset --hard "$GITHUB_REV"
@@ -52,7 +50,6 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/coverage.yml#L50
           aws s3 cp lcov-all.info.xz s3://rubyci/coverage/lcov-all-"$GITHUB_SHA".info.xz
           aws s3 sync lcov-out s3://rubyci/coverage-latest-html
         env:
-          GITHUB_SHA: ${{ github.sha }}
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
         if: github.event_name == 'schedule'
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index 2e53d52..7718e01 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -25,8 +25,6 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/macos.yml#L25
       # Not using official actions/checkout because it's unstable and sometimes doesn't work for a fork.
       - name: Checkout ruby/ruby
         run: git clone --depth=50 https://github.com/ruby/ruby . && git reset --hard "$GITHUB_SHA"
-        env:
-          GITHUB_SHA: ${{ github.sha }}
         if: github.event_name == 'push'
       - name: Checkout a pull request
         run: git clone --depth=50 "--branch=$GITHUB_BRANCH" "https://github.com/${GITHUB_REPO}" . && git reset --hard "$GITHUB_REV"
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
index 7b58b32..e92e856 100644
--- a/.github/workflows/ubuntu.yml
+++ b/.github/workflows/ubuntu.yml
@@ -24,8 +24,6 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/ubuntu.yml#L24
       # Not using official actions/checkout because it's unstable and sometimes doesn't work for a fork.
       - name: Checkout ruby/ruby
         run: git clone --depth=50 https://github.com/ruby/ruby . && git reset --hard "$GITHUB_SHA"
-        env:
-          GITHUB_SHA: ${{ github.sha }}
         if: github.event_name == 'push'
       - name: Checkout a pull request
         run: git clone --depth=50 "--branch=$GITHUB_BRANCH" "https://github.com/${GITHUB_REPO}" . && git reset --hard "$GITHUB_REV"
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]