[前][次][番号順一覧][スレッド一覧]

ruby-changes:56936

From: Hiroshi <ko1@a...>
Date: Mon, 12 Aug 2019 12:59:08 +0900 (JST)
Subject: [ruby-changes:56936] Hiroshi SHIBATA: 8a8f680f01 (master): Re-use GITHUB_ACTION variables for filtering bundler examples.

https://git.ruby-lang.org/ruby.git/commit/?id=8a8f680f01

From 8a8f680f017d0d4c410f17ec74e06d0436dcbe83 Mon Sep 17 00:00:00 2001
From: Hiroshi SHIBATA <hsbt@r...>
Date: Mon, 12 Aug 2019 08:23:27 +0900
Subject: Re-use GITHUB_ACTION variables for filtering bundler examples.


diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index c893340..68fba08 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -37,6 +37,5 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/macos.yml#L37
         env:
           TESTOPTS: "$JOBS -q --tty=no"
           MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies
-          CI: "true"
       - name: Leaked Globals
         run: make -s leaked-globals
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
index 0ae5160..d7a6cba 100644
--- a/.github/workflows/ubuntu.yml
+++ b/.github/workflows/ubuntu.yml
@@ -37,7 +37,5 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/ubuntu.yml#L37
       - run: make $JOBS
       - name: make test-bundler/test-bundled-gems
         run: make -s ${{ matrix.test_task }}
-        env:
-          CI: "true"
       - name: Leaked Globals
         run: make -s leaked-globals
diff --git a/spec/bundler/bundler/source_spec.rb b/spec/bundler/bundler/source_spec.rb
index 9ae6b3e..46d8693 100644
--- a/spec/bundler/bundler/source_spec.rb
+++ b/spec/bundler/bundler/source_spec.rb
@@ -56,7 +56,7 @@ RSpec.describe Bundler::Source do https://github.com/ruby/ruby/blob/trunk/spec/bundler/bundler/source_spec.rb#L56
         context "with a different version" do
           let(:locked_gem) { double(:locked_gem, :name => "nokogiri", :version => "< 1.5") }
 
-          context "with color", :non_windows do
+          context "with color", :no_color_tty do
             before { Bundler.ui = Bundler::UI::Shell.new }
 
             it "should return a string with the spec name and version and locked spec version" do
@@ -77,7 +77,7 @@ RSpec.describe Bundler::Source do https://github.com/ruby/ruby/blob/trunk/spec/bundler/bundler/source_spec.rb#L77
           let(:spec) { double(:spec, :name => "nokogiri", :version => "1.6.1", :platform => rb) }
           let(:locked_gem) { double(:locked_gem, :name => "nokogiri", :version => "1.7.0") }
 
-          context "with color", :non_windows do
+          context "with color", :no_color_tty do
             before { Bundler.ui = Bundler::UI::Shell.new }
 
             it "should return a string with the locked spec version in yellow" do
@@ -98,7 +98,7 @@ RSpec.describe Bundler::Source do https://github.com/ruby/ruby/blob/trunk/spec/bundler/bundler/source_spec.rb#L98
           let(:spec) { double(:spec, :name => "nokogiri", :version => "1.7.1", :platform => rb) }
           let(:locked_gem) { double(:locked_gem, :name => "nokogiri", :version => "1.7.0") }
 
-          context "with color", :non_windows do
+          context "with color", :no_color_tty do
             before { Bundler.ui = Bundler::UI::Shell.new }
 
             it "should return a string with the locked spec version in green" do
diff --git a/spec/bundler/spec_helper.rb b/spec/bundler/spec_helper.rb
index 53e5999..2482fc0 100644
--- a/spec/bundler/spec_helper.rb
+++ b/spec/bundler/spec_helper.rb
@@ -73,7 +73,7 @@ RSpec.configure do |config| https://github.com/ruby/ruby/blob/trunk/spec/bundler/spec_helper.rb#L73
   config.filter_run_excluding :git => RequirementChecker.against(git_version)
   config.filter_run_excluding :bundler => RequirementChecker.against(Bundler::VERSION.split(".")[0])
   config.filter_run_excluding :ruby_repo => !(ENV["BUNDLE_RUBY"] && ENV["BUNDLE_GEM"]).nil?
-  config.filter_run_excluding :non_windows => Gem.win_platform? || ENV["CI"]
+  config.filter_run_excluding :no_color_tty => Gem.win_platform? || !!ENV["GITHUB_ACTION"]
 
   config.filter_run_when_matching :focus unless ENV["CI"]
 
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]