ruby-changes:56830
From: Takashi <ko1@a...>
Date: Tue, 6 Aug 2019 00:48:34 +0900 (JST)
Subject: [ruby-changes:56830] Takashi Kokubun: e80f407ed4 (master): Give up stabilizing TestProcess on Travis osx
https://git.ruby-lang.org/ruby.git/commit/?id=e80f407ed4 From e80f407ed4eafad4c544d7b2de507a0f4386f0a7 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun <takashikkbn@g...> Date: Tue, 6 Aug 2019 00:43:46 +0900 Subject: Give up stabilizing TestProcess on Travis osx They have been too unstable. Revert "Extend sleep before sending USR1 in TestProcess" This reverts commit aaf69a8ba866193863a7eafe5c6044844bd71bc3. Revert "Extend sleep before sending USR1 in TestProcess" This reverts commit 076f3fcf11a061394d3d5f8c671512df1e983023. diff --git a/test/excludes/_travis/osx/TestProcess.rb b/test/excludes/_travis/osx/TestProcess.rb new file mode 100644 index 0000000..5aa03d5 --- /dev/null +++ b/test/excludes/_travis/osx/TestProcess.rb @@ -0,0 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/test/excludes/_travis/osx/TestProcess.rb#L1 +# These tests randomly hang forever. For testing other things properly, skipped for now. + +# https://travis-ci.org/ruby/ruby/jobs/566409880 +exclude(:test_execopts_redirect_open_fifo_interrupt_raise, 'This test randomly hangs on Travis osx') + +# https://travis-ci.org/ruby/ruby/jobs/567547060 +exclude(:test_execopts_redirect_open_fifo_interrupt_print, 'This test randomly hangs on Travis osx') diff --git a/test/ruby/test_process.rb b/test/ruby/test_process.rb index 1d20c11..83c9c6a 100644 --- a/test/ruby/test_process.rb +++ b/test/ruby/test_process.rb @@ -665,7 +665,7 @@ class TestProcess < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_process.rb#L665 end EOS assert_equal("start\n", io.gets) - sleep 3 + sleep 0.5 Process.kill(:USR1, io.pid) assert_equal("ok\n", io.read) } @@ -686,7 +686,7 @@ class TestProcess < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_process.rb#L686 system("cat", :in => "fifo") EOS assert_equal("start\n", io.gets) - sleep 3 # wait for the child to stop at opening "fifo" + sleep 0.2 # wait for the child to stop at opening "fifo" Process.kill(:USR1, io.pid) assert_equal("trap\n", io.readpartial(8)) File.write("fifo", "ok\n") -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/