[前][次][番号順一覧][スレッド一覧]

ruby-changes:56819

From: Hiroshi <ko1@a...>
Date: Mon, 5 Aug 2019 18:47:24 +0900 (JST)
Subject: [ruby-changes:56819] Hiroshi SHIBATA: 8eb2921f56 (master): [rubygems/rubygems] Fixed to warn with shadowing outer local variable.

https://git.ruby-lang.org/ruby.git/commit/?id=8eb2921f56

From 8eb2921f568f0ebc1a0f61b45297c77516f602b5 Mon Sep 17 00:00:00 2001
From: Hiroshi SHIBATA <hsbt@r...>
Date: Wed, 31 Jul 2019 07:54:45 +0800
Subject: [rubygems/rubygems] Fixed to warn with shadowing outer local
 variable.

https://github.com/rubygems/rubygems/commit/b0588a87b1

diff --git a/lib/rubygems/ext/ext_conf_builder.rb b/lib/rubygems/ext/ext_conf_builder.rb
index 97681fa..88be7ec 100644
--- a/lib/rubygems/ext/ext_conf_builder.rb
+++ b/lib/rubygems/ext/ext_conf_builder.rb
@@ -45,12 +45,12 @@ class Gem::Ext::ExtConfBuilder < Gem::Ext::Builder https://github.com/ruby/ruby/blob/trunk/lib/rubygems/ext/ext_conf_builder.rb#L45
         cmd.push(*args)
 
         begin
-          run(cmd, results) do |status, results|
+          run(cmd, results) do |s, r|
             if File.exist? 'mkmf.log'
-              unless status.success?
-                results << "To see why this extension failed to compile, please check" \
+              unless s.success?
+                r << "To see why this extension failed to compile, please check" \
                   " the mkmf.log which can be found here:\n"
-                results << "  " + File.join(dest_path, 'mkmf.log') + "\n"
+                r << "  " + File.join(dest_path, 'mkmf.log') + "\n"
               end
               FileUtils.mv 'mkmf.log', dest_path
             end
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]