[前][次][番号順一覧][スレッド一覧]

ruby-changes:56509

From: Yusuke <ko1@a...>
Date: Mon, 15 Jul 2019 00:10:27 +0900 (JST)
Subject: [ruby-changes:56509] Yusuke Endoh: 517c8a5324 (master): dir.c (dir_each_entry): remove unnecessary check

https://git.ruby-lang.org/ruby.git/commit/?id=517c8a5324

From 517c8a532425a28ee2641fc100a91a691b501fe8 Mon Sep 17 00:00:00 2001
From: Yusuke Endoh <mame@r...>
Date: Mon, 15 Jul 2019 00:08:34 +0900
Subject: dir.c (dir_each_entry): remove unnecessary check

I guess that this check was to detect re-entrance (maybe callcc?).
But currently it does not work as intended.

diff --git a/dir.c b/dir.c
index 1dbedb7..18c10f2 100644
--- a/dir.c
+++ b/dir.c
@@ -858,7 +858,6 @@ dir_each_entry(VALUE dir, VALUE (*each)(VALUE, VALUE), VALUE arg, int children_o https://github.com/ruby/ruby/blob/trunk/dir.c#L858
 #endif
 	path = rb_external_str_new_with_enc(name, namlen, dirp->enc);
 	(*each)(arg, path);
-	if (dirp->dir == NULL) dir_closed();
     }
     return dir;
 }
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]