ruby-changes:56218
From: Yusuke <ko1@a...>
Date: Tue, 25 Jun 2019 23:35:03 +0900 (JST)
Subject: [ruby-changes:56218] Yusuke Endoh: 730aeb2523 (trunk): Revert 518adcca0a and dbe232e24e
https://git.ruby-lang.org/ruby.git/commit/?id=730aeb2523 From 730aeb2523fadd816b07e0e5322fb79841efc709 Mon Sep 17 00:00:00 2001 From: Yusuke Endoh <mame@r...> Date: Tue, 25 Jun 2019 23:31:49 +0900 Subject: Revert 518adcca0a and dbe232e24e 518adcca0a: "Try using arm32 implementation for fibers." dbe232e24e: "Order of arguments might be incorrect in arm32 coroutine implementation." It seems to cause SEGV consistently on Ubuntu armv7l eabihf: https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20190625T081710Z.fail.html.gz https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20190625T111708Z.fail.html.gz diff --git a/configure.ac b/configure.ac index 8c431ad..5f2fe6b 100644 --- a/configure.ac +++ b/configure.ac @@ -2272,9 +2272,6 @@ AS_CASE(["$rb_cv_fiber_coroutine"], [yes|''], [ https://github.com/ruby/ruby/blob/trunk/configure.ac#L2272 [x64-mingw32], [ rb_cv_fiber_coroutine=win64 ], - [armv7*-linux-*], [ - rb_cv_fiber_coroutine=arm32 - ], [aarch64-linux], [ rb_cv_fiber_coroutine=arm64 ], diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S index b2bb2ae..c2b93d0 100644 --- a/coroutine/arm32/Context.S +++ b/coroutine/arm32/Context.S @@ -9,10 +9,6 @@ https://github.com/ruby/ruby/blob/trunk/coroutine/arm32/Context.S#L9 .globl coroutine_transfer coroutine_transfer: - stmia r0!, {r4-r11,sp,lr} - ldmia r1!, {r4-r11,sp,pc} + stmia r1!, {r4-r11,sp,lr} + ldmia r0!, {r4-r11,sp,pc} bx lr - -#if defined(__linux__) && defined(__ELF__) -.section .note.GNU-stack,"",%progbits -#endif -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/