[前][次][番号順一覧][スレッド一覧]

ruby-changes:55580

From: Takashi <ko1@a...>
Date: Sun, 28 Apr 2019 21:13:10 +0900 (JST)
Subject: [ruby-changes:55580] Takashi Kokubun:d835ed4df1 (trunk): Define merger.rb's methods under Merger namespace

https://git.ruby-lang.org/ruby.git/commit/?id=d835ed4df1

From d835ed4df1ae2bf317db41a8009b1fad143c94f1 Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Sun, 28 Apr 2019 21:02:01 +0900
Subject: Define merger.rb's methods under Merger namespace

so that we do not monkey-patch all classes by defining methods on
top-level (Object class).

Not arranging indentation in it to keep `git blame` for now.

diff --git a/tool/merger.rb b/tool/merger.rb
index 4f21e81..a210a92 100755
--- a/tool/merger.rb
+++ b/tool/merger.rb
@@ -14,8 +14,10 @@ require 'uri' https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L14
 $repos = 'svn+ssh://svn@c.../ruby/'
 ENV['LC_ALL'] = 'C'
 
-def help
-  puts <<-end
+module Merger
+  class << self
+    def help
+      puts <<-end
 \e[1msimple backport\e[0m
   ruby #$0 1234
 
@@ -41,11 +43,10 @@ def help https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L43
   ruby #$0 removetag 2.2.9
 
 \e[33;1m* all operations shall be applied to the working directory.\e[0m
-end
-end
-
-# Prints the version of Ruby found in version.h
+      end
+    end
 
+    # Prints the version of Ruby found in version.h
 def version
   v = p = nil
   open 'version.h', 'rb' do |f|
@@ -201,20 +202,22 @@ end https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L202
 def default_merge_branch
   %r{^URL: .*/branches/ruby_1_8_} =~ `svn info` ? 'branches/ruby_1_8' : 'trunk'
 end
+  end # class << self
+end # module Merger
 
 case ARGV[0]
 when "teenyup"
-  version_up(:teeny)
+  Merger.version_up(:teeny)
   system 'svn diff version.h'
 when "up", /\A(ver|version|rev|revision|lv|level|patch\s*level)\s*up/
-  version_up
+  Merger.version_up
   system 'svn diff version.h'
 when "tag"
-  tag :interactive, ARGV[1]
+  Merger.tag :interactive, ARGV[1]
 when /\A(?:remove|rm|del)_?tag\z/
-  remove_tag :interactive, ARGV[1]
+  Merger.remove_tag :interactive, ARGV[1]
 when nil, "-h", "--help"
-  help
+  Merger.help
   exit
 else
   system 'svn up'
@@ -230,7 +233,7 @@ else https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L233
     tickets = ''
   end
 
-  q = $repos + (ARGV[1] || default_merge_branch)
+  q = $repos + (ARGV[1] || Merger.default_merge_branch)
   revstr = ARGV[0].delete('^, :\-0-9a-fA-F')
   revs = revstr.split(/[,\s]+/)
   commit_message = ''
@@ -274,18 +277,18 @@ else https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L277
   end
 
   if `svn diff --diff-cmd=diff -x -upw`.empty?
-    interactive 'Nothing is modified, right?' do
+    Merger.interactive 'Nothing is modified, right?' do
     end
   end
 
-  version_up
+  Merger.version_up
   f = Tempfile.new 'merger.rb'
   f.printf "merge revision(s) %s:%s", revstr, tickets
   f.write commit_message
   f.flush
   f.close
 
-  interactive 'conflicts resolved?', f.path do
+  Merger.interactive 'conflicts resolved?', f.path do
     IO.popen(ENV["PAGER"] || "less", "w") do |g|
       g << `svn stat`
       g << "\n\n"
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]