ruby-changes:55525
From: Takashi <ko1@a...>
Date: Thu, 25 Apr 2019 18:55:27 +0900 (JST)
Subject: [ruby-changes:55525] Takashi Kokubun:b2e92bfd9f (trunk): Resurrect `make xxx-github PR=1234` interface
From b2e92bfd9f25274277f15faa6e9a70a7d0a36dfe Mon Sep 17 00:00:00 2001 From: Takashi Kokubun <takashikkbn@g...> Date: Thu, 25 Apr 2019 18:54:43 +0900 Subject: Resurrect `make xxx-github PR=1234` interface `call xxx, yyy` seems to pass " yyy" instead of "yyy". diff --git a/defs/gmake.mk b/defs/gmake.mk index 213eb33..e2e4a3b 100644 --- a/defs/gmake.mk +++ b/defs/gmake.mk @@ -161,7 +161,7 @@ REMOTE_GUTHUB_URL = $(shell git -C "$(srcdir)" config remote.github.url) https://github.com/ruby/ruby/blob/trunk/#L161 .PHONY: fetch-github fetch-github: - $(call fetch-github, $(PR)) + $(call fetch-github,$(PR)) define fetch-github $(if $(1),,\ @@ -183,7 +183,7 @@ checkout-github: fetch-github https://github.com/ruby/ruby/blob/trunk/#L183 .PHONY: merge-github merge-github: fetch-github - $(call merge-github, $(PR)) + $(call merge-github,$(PR)) define merge-github $(eval GITHUB_MERGE_BASE := $(shell git -C "$(srcdir)" log -1 --format=format:%H)) -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/