[前][次][番号順一覧][スレッド一覧]

ruby-changes:55428

From: k0kubun <ko1@a...>
Date: Sat, 20 Apr 2019 14:46:00 +0900 (JST)
Subject: [ruby-changes:55428] k0kubun:r67637 (trunk): Revert "Skip ISeq reference for stale_units for debugging"

k0kubun	2019-04-20 14:45:56 +0900 (Sat, 20 Apr 2019)

  New Revision: 67637

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=67637

  Log:
    Revert "Skip ISeq reference for stale_units for debugging"
    
    This reverts commit 4bd4d4e4cfd164f767e88f844cf10b06faee14b9.
    
    Sorry, let me test another one first

  Modified files:
    trunk/mjit.c
Index: mjit.c
===================================================================
--- mjit.c	(revision 67636)
+++ mjit.c	(revision 67637)
@@ -174,21 +174,7 @@ free_list(struct rb_mjit_unit_list *list https://github.com/ruby/ruby/blob/trunk/mjit.c#L174
     list_for_each_safe(&list->head, unit, next, unode) {
         list_del(&unit->unode);
         if (!close_handle_p) unit->handle = NULL; /* Skip dlclose in free_unit() */
-
-        if (list == &stale_units) { // `free_unit(unit)` crashes after GC.compact on `stale_units`
-            /*
-             * TODO: REVERT THIS BRANCH
-             * Debug the crash on stale_units w/ GC.compact and just use `free_unit(unit)`!!
-             */
-            if (unit->handle && dlclose(unit->handle)) {
-                mjit_warning("failed to close handle for u%d: %s", unit->id, dlerror());
-            }
-            clean_object_files(unit);
-            free(unit);
-        }
-        else {
-            free_unit(unit);
-        }
+        free_unit(unit);
     }
     list->length = 0;
 }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]