[前][次][番号順一覧][スレッド一覧]

ruby-changes:55224

From: k0kubun <ko1@a...>
Date: Thu, 4 Apr 2019 10:34:59 +0900 (JST)
Subject: [ruby-changes:55224] k0kubun:r67431 (trunk): Revert "Introduce inline cache for invokesuper"

k0kubun	2019-04-04 10:34:53 +0900 (Thu, 04 Apr 2019)

  New Revision: 67431

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=67431

  Log:
    Revert "Introduce inline cache for invokesuper"
    
    This reverts commit d147ad6231aebb1d478162fb8e109e0c6a696169.
    
    because failing on CI:
    http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1916925

  Modified files:
    trunk/vm_insnhelper.c
Index: vm_insnhelper.c
===================================================================
--- vm_insnhelper.c	(revision 67430)
+++ vm_insnhelper.c	(revision 67431)
@@ -2796,13 +2796,7 @@ vm_search_super_method(const rb_control_ https://github.com/ruby/ruby/blob/trunk/vm_insnhelper.c#L2796
         CC_SET_FASTPATH(cc, vm_call_method_missing, TRUE);
     }
     else {
-#if OPT_INLINE_METHOD_CACHE
-        if (LIKELY(GET_GLOBAL_METHOD_STATE() == cc->method_state && RCLASS_SERIAL(klass) == cc->class_serial &&
-                   ci->mid == cc->me->def->original_id))
-            return;
-        cc->method_state = GET_GLOBAL_METHOD_STATE();
-        cc->class_serial = RCLASS_SERIAL(klass);
-#endif
+	/* TODO: use inline cache */
 	cc->me = rb_callable_method_entry(klass, ci->mid);
         CC_SET_FASTPATH(cc, vm_call_super_method, TRUE);
     }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]