k0kubun	2019-04-03 21:48:02 +0900 (Wed, 03 Apr 2019)

  New Revision: 67428

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=67428

  Log:
    Partially allow failures in test-bundled-gems
    
    Tests of minitest randomly fails with strange errors:
    https://dev.azure.com/rubylang/ruby/_build/results?buildId=303
    https://dev.azure.com/rubylang/ruby/_build/results?buildId=314
    
    Instead of marking `continueOnError` for all, let me select
    failure-allowed gems individually.

  Modified files:
    trunk/Makefile.in
    trunk/azure-pipelines.yml
Index: azure-pipelines.yml
===================================================================
--- azure-pipelines.yml	(revision 67427)
+++ azure-pipelines.yml	(revision 67428)
@@ -7,6 +7,8 @@ jobs: https://github.com/ruby/ruby/blob/trunk/azure-pipelines.yml#L7
     matrix:
       bundled_gems:
         task: test-bundled-gems
+        TEST_BUNDLED_GEMS_ALLOW_FAILURES: |
+          minitest
       bundler:
         task: test-bundler
   steps:
@@ -24,7 +26,7 @@ jobs: https://github.com/ruby/ruby/blob/trunk/azure-pipelines.yml#L26
   - script: |
       TRAVIS=1 make $(task)
     displayName: "test"
-    continueOnError: true # test-bundled-gems and test-bundler are failing on Linux. TODO: fix them and remove this line.
+    continueOnError: true # test-bundler is failing on Linux. TODO: fix it and remove this line.
 
 - job: macOS
   pool:
@@ -37,6 +39,8 @@ jobs: https://github.com/ruby/ruby/blob/trunk/azure-pipelines.yml#L39
 #        task: test-spec
       bundled_gems:
         task: test-bundled-gems
+        TEST_BUNDLED_GEMS_ALLOW_FAILURES: |
+          minitest
       bundler:
         task: test-bundler
   steps:
Index: Makefile.in
===================================================================
--- Makefile.in	(revision 67427)
+++ Makefile.in	(revision 67428)
@@ -529,10 +529,17 @@ enc/encinit.$(OBJEXT): enc/encinit.c $(S https://github.com/ruby/ruby/blob/trunk/Makefile.in#L529
 
 cont.$(OBJEXT): $(COROUTINE_H)
 
+# Override this to allow failure of specific gems on CI
+TEST_BUNDLED_GEMS_ALLOW_FAILURES =
+
 test-bundled-gems-run:
 	$(Q) set -e; while read gem _; do \
-	  echo testing $$gem gem && \
-	  $(XRUBY) -C $(srcdir)/gems/src/$$gem -Ilib ../../../.bundle/bin/rake; \
+	  echo testing $$gem gem; \
+	  if echo $(TEST_BUNDLED_GEMS_ALLOW_FAILURES) | grep -q $$gem; then \
+	    $(XRUBY) -C $(srcdir)/gems/src/$$gem -Ilib ../../../.bundle/bin/rake || true; \
+	  else \
+	    $(XRUBY) -C $(srcdir)/gems/src/$$gem -Ilib ../../../.bundle/bin/rake; \
+	  fi; \
 	done < $(srcdir)/gems/bundled_gems
 
 update-src::

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/