[前][次][番号順一覧][スレッド一覧]

ruby-changes:54855

From: naruse <ko1@a...>
Date: Wed, 13 Feb 2019 13:32:08 +0900 (JST)
Subject: [ruby-changes:54855] naruse:r67061 (trunk): Remove message to recommend to repot bug

naruse	2019-02-13 13:32:03 +0900 (Wed, 13 Feb 2019)

  New Revision: 67061

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=67061

  Log:
    Remove message to recommend to repot bug
    
    This message is showed on SEGV, but it is usually caused by 3rd party
    libraries and we don't help reporters well. I concluded this message
    doesn't help users as expected.

  Modified files:
    trunk/error.c
Index: error.c
===================================================================
--- error.c	(revision 67060)
+++ error.c	(revision 67061)
@@ -60,15 +60,6 @@ static ID id_warn; https://github.com/ruby/ruby/blob/trunk/error.c#L60
 
 extern const char ruby_description[];
 
-static const char REPORTBUG_MSG[] =
-	"[NOTE]\n" \
-	"You may have encountered a bug in the Ruby interpreter" \
-	" or extension libraries.\n" \
-	"Bug reports are welcome.\n" \
-	""
-	"For details: https://www.ruby-lang.org/bugreport.html\n\n" \
-    ;
-
 static const char *
 rb_strerrno(int err)
 {
@@ -548,7 +539,6 @@ bug_report_end(FILE *out) https://github.com/ruby/ruby/blob/trunk/error.c#L539
 	    (*reporter->func)(out, reporter->data);
 	}
     }
-    fputs(REPORTBUG_MSG, out);
     postscript_dump(out);
 }
 
@@ -652,8 +642,6 @@ rb_async_bug_errno(const char *mesg, int https://github.com/ruby/ruby/blob/trunk/error.c#L642
     }
     WRITE_CONST(2, "\n\n");
     write_or_abort(2, ruby_description, strlen(ruby_description));
-    WRITE_CONST(2, "\n\n");
-    WRITE_CONST(2, REPORTBUG_MSG);
     abort();
 }
 

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]