[前][次][番号順一覧][スレッド一覧]

ruby-changes:54807

From: k0kubun <ko1@a...>
Date: Thu, 7 Feb 2019 22:57:32 +0900 (JST)
Subject: [ruby-changes:54807] k0kubun:r67026 (trunk): test_rinda.rb: give up stabilizing this test

k0kubun	2019-02-07 22:57:27 +0900 (Thu, 07 Feb 2019)

  New Revision: 67026

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=67026

  Log:
    test_rinda.rb: give up stabilizing this test
    
    on --jit-wait. It's randomly failing and it's unlikely to be detecting
    any MJIT's bug.
    
    https://app.wercker.com/ruby/ruby/runs/mjit-test2/5c5c2339940b5200f01a0822?step=5c5c2b9fcfa0fc000741d940

  Modified files:
    trunk/test/rinda/test_rinda.rb
Index: test/rinda/test_rinda.rb
===================================================================
--- test/rinda/test_rinda.rb	(revision 67025)
+++ test/rinda/test_rinda.rb	(revision 67026)
@@ -657,6 +657,7 @@ class TestRingServer < Test::Unit::TestC https://github.com/ruby/ruby/blob/trunk/test/rinda/test_rinda.rb#L657
   end
 
   def test_do_reply_local
+    skip 'timeout-based test becomes unstable with --jit-wait' if RubyVM::MJIT.enabled?
     with_timeout(10) {_test_do_reply_local}
   end
 
@@ -788,7 +789,6 @@ class TestRingServer < Test::Unit::TestC https://github.com/ruby/ruby/blob/trunk/test/rinda/test_rinda.rb#L789
   private
 
   def with_timeout(n)
-    n *= 10 if RubyVM::MJIT.enabled? # for --jit-wait
     aoe = Thread.abort_on_exception
     Thread.abort_on_exception = true
     tl0 = Thread.list
@@ -822,7 +822,6 @@ class TestRingServer < Test::Unit::TestC https://github.com/ruby/ruby/blob/trunk/test/rinda/test_rinda.rb#L822
   end
 
   def wait_for(n)
-    n *= 10 if RubyVM::MJIT.enabled? # for --jit-wait
     t = n + Process.clock_gettime(Process::CLOCK_MONOTONIC, :second)
     until yield
       if t < Process.clock_gettime(Process::CLOCK_MONOTONIC, :second)

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]