[前][次][番号順一覧][スレッド一覧]

ruby-changes:54381

From: ko1 <ko1@a...>
Date: Fri, 28 Dec 2018 02:39:22 +0900 (JST)
Subject: [ruby-changes:54381] ko1:r66595 (trunk): fix missed script_compiled events. [Bug #15471]

ko1	2018-12-28 02:39:17 +0900 (Fri, 28 Dec 2018)

  New Revision: 66595

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=66595

  Log:
    fix missed script_compiled events. [Bug #15471]
    
    * ruby.c (process_options): script_compiled events are missed on
      command line -e or specified file. this commit fix it.
      [Bug #15471]
    
      This patch should be backport to Ruby 2.6 branch.
    
    * vm_core.h (rb_exec_event_hook_script_compiled): introduce utility
      function to invoke a script_compiled event.

  Modified files:
    trunk/load.c
    trunk/ruby.c
    trunk/vm_core.h
    trunk/vm_eval.c
Index: load.c
===================================================================
--- load.c	(revision 66594)
+++ load.c	(revision 66595)
@@ -608,9 +608,8 @@ rb_load_internal0(rb_execution_context_t https://github.com/ruby/ruby/blob/trunk/load.c#L608
 			    fname, rb_realpath_internal(Qnil, fname, 1), NULL);
 	    rb_ast_dispose(ast);
 	}
-        EXEC_EVENT_HOOK(ec, RUBY_EVENT_SCRIPT_COMPILED,
-                        ec->cfp->self, 0, 0, 0, (VALUE)iseq);
-	rb_iseq_eval(iseq);
+        rb_exec_event_hook_script_compiled(ec, iseq, Qnil);
+        rb_iseq_eval(iseq);
     }
     EC_POP_TAG();
 
Index: vm_core.h
===================================================================
--- vm_core.h	(revision 66594)
+++ vm_core.h	(revision 66595)
@@ -1882,6 +1882,14 @@ rb_vm_global_hooks(const rb_execution_co https://github.com/ruby/ruby/blob/trunk/vm_core.h#L1882
 #define EXEC_EVENT_HOOK_AND_POP_FRAME(ec_, flag_, self_, id_, called_id_, klass_, data_) \
   EXEC_EVENT_HOOK_ORIG(ec_, rb_vm_global_hooks(ec_), flag_, self_, id_, called_id_, klass_, data_, 1)
 
+static inline void
+rb_exec_event_hook_script_compiled(rb_execution_context_t *ec, const rb_iseq_t *iseq, VALUE eval_script)
+{
+    EXEC_EVENT_HOOK(ec, RUBY_EVENT_SCRIPT_COMPILED, ec->cfp->self, 0, 0, 0,
+                    NIL_P(eval_script) ? (VALUE)iseq : 
+                    rb_ary_new_from_args(2, eval_script, (VALUE)iseq));
+}
+
 RUBY_SYMBOL_EXPORT_BEGIN
 
 int rb_thread_check_trap_pending(void);
Index: vm_eval.c
===================================================================
--- vm_eval.c	(revision 66594)
+++ vm_eval.c	(revision 66595)
@@ -1293,8 +1293,8 @@ eval_make_iseq(VALUE src, VALUE fname, i https://github.com/ruby/ruby/blob/trunk/vm_eval.c#L1293
 	printf("%s\n", StringValuePtr(disasm));
     }
 
-    EXEC_EVENT_HOOK(GET_EC(), RUBY_EVENT_SCRIPT_COMPILED, GET_EC()->cfp->self, 0, 0, 0,
-                    rb_ary_new_from_args(2, src, (VALUE)iseq));
+    rb_exec_event_hook_script_compiled(GET_EC(), iseq, src);
+
     return iseq;
 }
 
Index: ruby.c
===================================================================
--- ruby.c	(revision 66594)
+++ ruby.c	(revision 66595)
@@ -1863,6 +1863,18 @@ process_options(int argc, char **argv, r https://github.com/ruby/ruby/blob/trunk/ruby.c#L1863
 
     rb_set_safe_level(opt->safe_level);
 
+    {
+        rb_execution_context_t *ec = GET_EC();
+
+        if (opt->e_script) {
+            /* -e */
+            rb_exec_event_hook_script_compiled(ec, iseq, opt->e_script);
+        }
+        else {
+            /* file */
+            rb_exec_event_hook_script_compiled(ec, iseq, Qnil);
+        }
+    }
     return (VALUE)iseq;
 }
 

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]