[前][次][番号順一覧][スレッド一覧]

ruby-changes:54228

From: duerst <ko1@a...>
Date: Wed, 19 Dec 2018 13:08:52 +0900 (JST)
Subject: [ruby-changes:54228] duerst:r66449 (trunk): avoid passing unnecessary options to download method

duerst	2018-12-19 13:08:46 +0900 (Wed, 19 Dec 2018)

  New Revision: 66449

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=66449

  Log:
    avoid passing unnecessary options to download method
    
    The option --unicode-beta for tool/downloader.rb introduced in
    r66448 must not be passed as an option to actual download machinery.
    Thanks to MSP-Greg (Greg L.) for bug report and patch.
    This closes issue #15434.

  Modified files:
    trunk/tool/downloader.rb
Index: tool/downloader.rb
===================================================================
--- tool/downloader.rb	(revision 66448)
+++ tool/downloader.rb	(revision 66449)
@@ -124,6 +124,11 @@ class Downloader https://github.com/ruby/ruby/blob/trunk/tool/downloader.rb#L124
     options = options.dup
     url = URI(url)
     dryrun = options.delete(:dryrun)
+
+    # remove from options (future use, see r66448), see L166
+    unicode_beta = options.delete(:unicode_beta)
+    puts "never" if unicode_beta == 'assigned but unused variable...'
+
     if name
       file = Pathname.new(under(dir, name))
     else

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]