[前][次][番号順一覧][スレッド一覧]

ruby-changes:53784

From: k0kubun <ko1@a...>
Date: Tue, 27 Nov 2018 01:14:02 +0900 (JST)
Subject: [ruby-changes:53784] k0kubun:r66002 (trunk): test_jit.rb: skip a test for Windows for now

k0kubun	2018-11-27 01:13:56 +0900 (Tue, 27 Nov 2018)

  New Revision: 66002

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=66002

  Log:
    test_jit.rb: skip a test for Windows for now
    
    https://ci.appveyor.com/project/ruby/ruby/builds/20558412
    
    removing CloseHandle disallows us to remove the DLL.

  Modified files:
    trunk/test/ruby/test_jit.rb
Index: test/ruby/test_jit.rb
===================================================================
--- test/ruby/test_jit.rb	(revision 66001)
+++ test/ruby/test_jit.rb	(revision 66002)
@@ -777,6 +777,10 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L777
   end
 
   def test_clean_objects_on_exec
+    if /mswin|mingw/ =~ RUBY_PLATFORM
+      # TODO: check call stack and close handle of code which is not on stack, and remove objects on best-effort basis
+      skip 'Removing so file being used does not work on Windows'
+    end
     Dir.mktmpdir("jit_test_clean_objects_on_exec_") do |dir|
       eval_with_jit({"TMPDIR"=>dir}, "#{<<~"begin;"}\n#{<<~"end;"}", min_calls: 1)
       begin;
@@ -786,7 +790,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L790
       error_message = "Undeleted files:\n  #{Dir.glob("#{dir}/*").join("\n  ")}\n"
       assert_send([Dir, :empty?, dir], error_message)
     end
-  end if system("which true")
+  end
 
   def test_lambda_longjmp
     assert_eval_with_jit("#{<<~"begin;"}\n#{<<~"end;"}", stdout: '5', success_count: 1)

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]