[前][次][番号順一覧][スレッド一覧]

ruby-changes:53660

From: k0kubun <ko1@a...>
Date: Tue, 20 Nov 2018 23:41:02 +0900 (JST)
Subject: [ruby-changes:53660] k0kubun:r65892 (trunk): configure.ac: disable native-fiber for MinGW

k0kubun	2018-11-20 23:40:55 +0900 (Tue, 20 Nov 2018)

  New Revision: 65892

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=65892

  Log:
    configure.ac: disable native-fiber for MinGW
    
    because it had already been SEGV-ed in pull request'S CI
    https://ci.appveyor.com/project/ruby/ruby/builds/20427065/job/32oahrcd58b8ubb1
    and has never worked on trunk either.
    
    Please make sure it does not SEGVs on your MinGW environment or pull
    request before enabling native fiber on MinGW.
    
    appveyor.yml: reverted commits to make CI green with native fiber
    test/excludes/_appveyor/msys2/TestArray.rb: ditto
    test/excludes/_appveyor/msys2/TestEnumerable.rb: ditto
    test/excludes/_appveyor/vs/TestArray.rb: ditto

  Added files:
    trunk/test/excludes/_appveyor/TestArray.rb
  Removed files:
    trunk/test/excludes/_appveyor/msys2/TestArray.rb
    trunk/test/excludes/_appveyor/msys2/TestEnumerable.rb
    trunk/test/excludes/_appveyor/vs/TestArray.rb
  Modified files:
    trunk/appveyor.yml
    trunk/configure.ac
Index: test/excludes/_appveyor/vs/TestArray.rb
===================================================================
--- test/excludes/_appveyor/vs/TestArray.rb	(revision 65891)
+++ test/excludes/_appveyor/vs/TestArray.rb	(nonexistent)
@@ -1,5 +0,0 @@ https://github.com/ruby/ruby/blob/trunk/test/excludes/_appveyor/vs/TestArray.rb#L0
-# https://ci.appveyor.com/project/ruby/ruby/builds/20339189/job/ltdpffep976xtj85
-# `test_push_over_ary_max': failed to allocate memory (NoMemoryError)
-exclude(:test_push_over_ary_max, 'Sometimes AppVeyor has insufficient memory to run this test')
-# https://ci.appveyor.com/project/ruby/ruby/builds/20427662/job/prq9i2lkfxv2j0uy
-exclude(:test_splice_over_ary_max, 'Sometimes AppVeyor has insufficient memory to run this test')

Property changes on: test/excludes/_appveyor/vs/TestArray.rb
___________________________________________________________________
Deleted: svn:eol-style
## -1 +0,0 ##
-LF
\ No newline at end of property
Index: test/excludes/_appveyor/msys2/TestArray.rb
===================================================================
--- test/excludes/_appveyor/msys2/TestArray.rb	(revision 65891)
+++ test/excludes/_appveyor/msys2/TestArray.rb	(nonexistent)
@@ -1,5 +0,0 @@ https://github.com/ruby/ruby/blob/trunk/test/excludes/_appveyor/msys2/TestArray.rb#L0
-# https://ci.appveyor.com/project/ruby/ruby/builds/20339189/job/ltdpffep976xtj85
-# `test_push_over_ary_max': failed to allocate memory (NoMemoryError)
-exclude(:test_push_over_ary_max, 'Sometimes AppVeyor has insufficient memory to run this test')
-# https://ci.appveyor.com/project/ruby/ruby/builds/20427662/job/prq9i2lkfxv2j0uy
-exclude(:test_splice_over_ary_max, 'Sometimes AppVeyor has insufficient memory to run this test')

Property changes on: test/excludes/_appveyor/msys2/TestArray.rb
___________________________________________________________________
Deleted: svn:eol-style
## -1 +0,0 ##
-LF
\ No newline at end of property
Index: test/excludes/_appveyor/msys2/TestEnumerable.rb
===================================================================
--- test/excludes/_appveyor/msys2/TestEnumerable.rb	(revision 65891)
+++ test/excludes/_appveyor/msys2/TestEnumerable.rb	(nonexistent)
@@ -1,2 +0,0 @@ https://github.com/ruby/ruby/blob/trunk/test/excludes/_appveyor/msys2/TestEnumerable.rb#L0
-# https://ci.appveyor.com/project/ruby/ruby/builds/20431217/job/97no5h1gqv50k1vf
-exclude(/^test_/, 'This has been broken after native-fiber')

Property changes on: test/excludes/_appveyor/msys2/TestEnumerable.rb
___________________________________________________________________
Deleted: svn:eol-style
## -1 +0,0 ##
-LF
\ No newline at end of property
Index: configure.ac
===================================================================
--- configure.ac	(revision 65891)
+++ configure.ac	(revision 65892)
@@ -2345,12 +2345,13 @@ AS_CASE(["$target_cpu-$target_os"], https://github.com/ruby/ruby/blob/trunk/configure.ac#L2345
     AC_DEFINE_UNQUOTED(FIBER_USE_COROUTINE, ["$COROUTINE_H"])
     AC_LIBOBJ([coroutine/x86/Context])
   ],
-  [x64-mingw32], [
-    AC_MSG_RESULT(win64)
-    COROUTINE_H=coroutine/win64/Context.h
-    AC_DEFINE_UNQUOTED(FIBER_USE_COROUTINE, ["$COROUTINE_H"])
-    AC_LIBOBJ([coroutine/win64/Context])
-  ],
+  # TODO: Enable this after AppVeyor msys2 build succeeds
+  # [x64-mingw32], [
+  #   AC_MSG_RESULT(win64)
+  #   COROUTINE_H=coroutine/win64/Context.h
+  #   AC_DEFINE_UNQUOTED(FIBER_USE_COROUTINE, ["$COROUTINE_H"])
+  #   AC_LIBOBJ([coroutine/win64/Context])
+  # ],
   [*], [
     AC_MSG_RESULT(no)
   ]
Index: test/excludes/_appveyor/TestArray.rb
===================================================================
--- test/excludes/_appveyor/TestArray.rb	(nonexistent)
+++ test/excludes/_appveyor/TestArray.rb	(revision 65892)
@@ -0,0 +1,5 @@ https://github.com/ruby/ruby/blob/trunk/test/excludes/_appveyor/TestArray.rb#L1
+# https://ci.appveyor.com/project/ruby/ruby/builds/20339189/job/ltdpffep976xtj85
+# `test_push_over_ary_max': failed to allocate memory (NoMemoryError)
+exclude(:test_push_over_ary_max, 'Sometimes AppVeyor has insufficient memory to run this test')
+# https://ci.appveyor.com/project/ruby/ruby/builds/20427662/job/prq9i2lkfxv2j0uy
+exclude(:test_splice_over_ary_max, 'Sometimes AppVeyor has insufficient memory to run this test')

Property changes on: test/excludes/_appveyor/TestArray.rb
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+LF
\ No newline at end of property
Index: appveyor.yml
===================================================================
--- appveyor.yml	(revision 65891)
+++ appveyor.yml	(revision 65892)
@@ -93,9 +93,9 @@ for: https://github.com/ruby/ruby/blob/trunk/appveyor.yml#L93
     - set /a JOBS=%NUMBER_OF_PROCESSORS%
     - nmake -l "TESTOPTS=-v -q" btest
     - nmake -l "TESTOPTS=-v -q" test-basic
-    - nmake -l "TESTOPTS=-q --subprocess-timeout-scale=3.0 --excludes=../test/excludes/_appveyor/vs -j%JOBS% --exclude win32ole --exclude test_bignum --exclude test_syntax --exclude test_open-uri --exclude test_bundled_ca" test-all
+    - nmake -l "TESTOPTS=-q --subprocess-timeout-scale=3.0 --excludes=../test/excludes/_appveyor -j%JOBS% --exclude win32ole --exclude test_bignum --exclude test_syntax --exclude test_open-uri --exclude test_bundled_ca" test-all
     # separately execute tests without -j which may crash worker with -j.
-    - nmake -l "TESTOPTS=-v --subprocess-timeout-scale=3.0 --excludes=../test/excludes/_appveyor/vs" test-all TESTS="../test/win32ole ../test/ruby/test_bignum.rb ../test/ruby/test_syntax.rb ../test/open-uri/test_open-uri.rb ../test/rubygems/test_bundled_ca.rb"
+    - nmake -l "TESTOPTS=-v --subprocess-timeout-scale=3.0 --excludes=../test/excludes/_appveyor" test-all TESTS="../test/win32ole ../test/ruby/test_bignum.rb ../test/ruby/test_syntax.rb ../test/open-uri/test_open-uri.rb ../test/rubygems/test_bundled_ca.rb"
     - nmake -l test-spec MSPECOPT=-fs # not using `-j` because sometimes `mspec -j` silently dies on Windows
 -
   matrix:
@@ -136,7 +136,7 @@ for: https://github.com/ruby/ruby/blob/trunk/appveyor.yml#L136
     - mingw32-make DESTDIR=../install install-nodoc
   test_script:
     - mingw32-make test
-    - mingw32-make test-all TESTOPTS="--retry --job-status=normal --show-skip --subprocess-timeout-scale=1.5 --excludes=../ruby/test/excludes/_appveyor/msys2 -j %JOBS% --exclude test_enumerator --exclude win32ole --exclude test_open-uri"
+    - mingw32-make test-all TESTOPTS="--retry --job-status=normal --show-skip --subprocess-timeout-scale=1.5 --excludes=../ruby/test/excludes/_appveyor -j %JOBS% --exclude win32ole --exclude test_open-uri"
     # separately execute tests without -j which may crash worker with -j.
-    - mingw32-make test-all TESTOPTS="--retry --job-status=normal --show-skip --subprocess-timeout-scale=1.5 --excludes=../ruby/test/excludes/_appveyor/msys2" TESTS="../ruby/test/ruby/test_enumerator.rb ../ruby/test/win32ole ../ruby/test/open-uri/test_open-uri.rb"
+    - mingw32-make test-all TESTOPTS="--retry --job-status=normal --show-skip --subprocess-timeout-scale=1.5 --excludes=../ruby/test/excludes/_appveyor" TESTS="../ruby/test/win32ole ../ruby/test/open-uri/test_open-uri.rb"
     - mingw32-make test-spec MSPECOPT=-fs # not using `-j` because sometimes `mspec -j` silently dies on Windows

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]