[前][次][番号順一覧][スレッド一覧]

ruby-changes:53285

From: marcandre <ko1@a...>
Date: Sat, 3 Nov 2018 02:52:01 +0900 (JST)
Subject: [ruby-changes:53285] marcandRe: r65500 (trunk): Revert "Matrix: Add #reflexive? method. [Fix GH-1730]"

marcandre	2018-11-03 02:51:56 +0900 (Sat, 03 Nov 2018)

  New Revision: 65500

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=65500

  Log:
    Revert "Matrix: Add #reflexive? method. [Fix GH-1730]"
    
    This reverts commit 19fe6552c456e41c0b85816806399ca1609255c0.

  Removed files:
    trunk/spec/ruby/library/matrix/reflexive_spec.rb
  Modified files:
    trunk/NEWS
    trunk/lib/matrix.rb
Index: spec/ruby/library/matrix/reflexive_spec.rb
===================================================================
--- spec/ruby/library/matrix/reflexive_spec.rb	(revision 65499)
+++ spec/ruby/library/matrix/reflexive_spec.rb	(nonexistent)
@@ -1,31 +0,0 @@ https://github.com/ruby/ruby/blob/trunk/spec/ruby/library/matrix/reflexive_spec.rb#L0
-require File.expand_path('../../../spec_helper', __FILE__)
-require 'matrix'
-
-ruby_version_is '2.6' do
-  describe "Matrix.reflexive?" do
-    it "returns true for a reflexive Matrix" do
-      Matrix[[1, 2, 3], [4, 1, 3], [5, 3, 1]].reflexive?.should be_true
-    end
-
-    it "returns true for a 0x0 empty matrix" do
-      Matrix.empty.reflexive?.should be_true
-    end
-
-    it "returns false for a non-reflexive Matrix" do
-      Matrix[[1, 1],[2, 2]].reflexive?.should be_false
-    end
-
-    it "raises an error for non-square matrices" do
-      [
-        Matrix[[0], [0]],
-        Matrix[[0, 0]],
-        Matrix.empty(0, 2),
-        Matrix.empty(2, 0),
-      ].each do |rectangular_matrix|
-        lambda {
-          rectangular_matrix.reflexive?
-        }.should raise_error(Matrix::ErrDimensionMismatch)
-      end
-    end
-  end
-end

Property changes on: spec/ruby/library/matrix/reflexive_spec.rb
___________________________________________________________________
Deleted: svn:eol-style
## -1 +0,0 ##
-LF
\ No newline at end of property
Index: NEWS
===================================================================
--- NEWS	(revision 65499)
+++ NEWS	(revision 65500)
@@ -313,8 +313,6 @@ sufficient information, see the ChangeLo https://github.com/ruby/ruby/blob/trunk/NEWS#L313
 
     * Matrix#antisymmetric?
 
-    * Matrix#reflexive?
-
 [Net]
 
   [New options]
Index: lib/matrix.rb
===================================================================
--- lib/matrix.rb	(revision 65499)
+++ lib/matrix.rb	(revision 65500)
@@ -814,15 +814,6 @@ class Matrix https://github.com/ruby/ruby/blob/trunk/lib/matrix.rb#L814
   end
 
   #
-  # Returns +true+ if this is a reflexive matrix.
-  # Raises an error if matrix is not square.
-  #
-  def reflexive?
-    Matrix.Raise ErrDimensionMismatch unless square?
-    each(:diagonal).all? { |e| e == 1 }
-  end
-
-  #
   # Returns +true+ if this is a unitary matrix
   # Raises an error if matrix is not square.
   #

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]