[前][次][番号順一覧][スレッド一覧]

ruby-changes:53115

From: nobu <ko1@a...>
Date: Tue, 23 Oct 2018 23:17:21 +0900 (JST)
Subject: [ruby-changes:53115] nobu:r65329 (trunk): test/unit.rb: fixed wrong method name

nobu	2018-10-23 23:17:16 +0900 (Tue, 23 Oct 2018)

  New Revision: 65329

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=65329

  Log:
    test/unit.rb: fixed wrong method name
    
    * test/lib/test/unit.rb (Test::Unit::Parallel#deal): fixed wrong
      method name at r36388.
    
    * test/testunit/test_parallel.rb (TestParallel::TestParallel#test_separate):
      refine the pattern to process IDs but not backtrace lines, and
      add a better message.

  Modified files:
    trunk/test/lib/test/unit.rb
    trunk/test/testunit/test_parallel.rb
Index: test/lib/test/unit.rb
===================================================================
--- test/lib/test/unit.rb	(revision 65328)
+++ test/lib/test/unit.rb	(revision 65329)
@@ -404,7 +404,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/test/lib/test/unit.rb#L404
           end
           if @options[:separate] and not bang
             worker.quit
-            worker = add_worker
+            worker = launch_worker
           end
           worker.run(task, type)
           @test_count += 1
Index: test/testunit/test_parallel.rb
===================================================================
--- test/testunit/test_parallel.rb	(revision 65328)
+++ test/testunit/test_parallel.rb	(revision 65329)
@@ -195,7 +195,8 @@ module TestParallel https://github.com/ruby/ruby/blob/trunk/test/testunit/test_parallel.rb#L195
       # this test depends to --jobs-status
       spawn_runner "--jobs-status", "--separate"
       buf = Timeout.timeout(TIMEOUT) {@test_out.read}
-      assert(buf.scan(/(\d+?)[:=]/).flatten.uniq.size > 1)
+      assert(buf.scan(/^\[\s*\d+\/\d+\]\s*(\d+?)=/).flatten.uniq.size > 1,
+             message("retried tests should run in different processes") {buf})
     end
   end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]