[前][次][番号順一覧][スレッド一覧]

ruby-changes:53095

From: k0kubun <ko1@a...>
Date: Tue, 23 Oct 2018 00:19:40 +0900 (JST)
Subject: [ruby-changes:53095] k0kubun:r65309 (trunk): test/ruby/test_string.rb: skip test_crypt for MJIT again

k0kubun	2018-10-23 00:19:34 +0900 (Tue, 23 Oct 2018)

  New Revision: 65309

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=65309

  Log:
    test/ruby/test_string.rb: skip test_crypt for MJIT again
    
    Partially reverting r65285. Actually this one is failing due to memory
    consumption on MJIT, so this seems not catching the bug of MJIT.
    
    test/ruby/test_io.rb: unify the skip message with it

  Modified files:
    trunk/test/ruby/test_io.rb
    trunk/test/ruby/test_string.rb
Index: test/ruby/test_string.rb
===================================================================
--- test/ruby/test_string.rb	(revision 65308)
+++ test/ruby/test_string.rb	(revision 65309)
@@ -647,6 +647,7 @@ CODE https://github.com/ruby/ruby/blob/trunk/test/ruby/test_string.rb#L647
   end
 
   def test_crypt
+    skip 'assert_no_memory_leak may consider MJIT memory usage as leak' if RubyVM::MJIT.enabled?
     assert_equal(S('aaGUC/JkO9/Sc'), S("mypassword").crypt(S("aa")))
     assert_not_equal(S('aaGUC/JkO9/Sc'), S("mypassword").crypt(S("ab")))
     assert_raise(ArgumentError) {S("mypassword").crypt(S(""))}
Index: test/ruby/test_io.rb
===================================================================
--- test/ruby/test_io.rb	(revision 65308)
+++ test/ruby/test_io.rb	(revision 65309)
@@ -3823,7 +3823,7 @@ __END__ https://github.com/ruby/ruby/blob/trunk/test/ruby/test_io.rb#L3823
   end
 
   def test_select_leak
-    skip 'MJIT uses too much memory' if RubyVM::MJIT.enabled?
+    skip 'assert_no_memory_leak may consider MJIT memory usage as leak' if RubyVM::MJIT.enabled?
     # avoid malloc arena explosion from glibc and jemalloc:
     env = {
       'MALLOC_ARENA_MAX' => '1',

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]