[前][次][番号順一覧][スレッド一覧]

ruby-changes:53071

From: k0kubun <ko1@a...>
Date: Mon, 22 Oct 2018 00:54:55 +0900 (JST)
Subject: [ruby-changes:53071] k0kubun:r65285 (trunk): try to remove some test skips for MJIT

k0kubun	2018-10-22 00:54:50 +0900 (Mon, 22 Oct 2018)

  New Revision: 65285

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=65285

  Log:
    try to remove some test skips for MJIT
    
    Eric Wong made some effort to keep compatibility around fd with MJIT.
    Also I'm hoping r65279 (and r65280) eliminates major MJIT bugs, so I
    want to start solely testing MJIT. Other test skips branched by MJIT
    enablement seemed reasonable to me.

  Modified files:
    trunk/test/-ext-/thread_fd_close/test_thread_fd_close.rb
    trunk/test/ruby/test_autoload.rb
    trunk/test/ruby/test_string.rb
    trunk/test/rubygems/test_gem_util.rb
Index: test/ruby/test_string.rb
===================================================================
--- test/ruby/test_string.rb	(revision 65284)
+++ test/ruby/test_string.rb	(revision 65285)
@@ -647,10 +647,6 @@ CODE https://github.com/ruby/ruby/blob/trunk/test/ruby/test_string.rb#L647
   end
 
   def test_crypt
-    if RubyVM::MJIT.enabled?
-      skip "This sometimes fails with -DMJIT_FORCE_ENABLE. This seems important to be fixed..."
-    end
-
     assert_equal(S('aaGUC/JkO9/Sc'), S("mypassword").crypt(S("aa")))
     assert_not_equal(S('aaGUC/JkO9/Sc'), S("mypassword").crypt(S("ab")))
     assert_raise(ArgumentError) {S("mypassword").crypt(S(""))}
Index: test/ruby/test_autoload.rb
===================================================================
--- test/ruby/test_autoload.rb	(revision 65284)
+++ test/ruby/test_autoload.rb	(revision 65285)
@@ -336,7 +336,6 @@ p Foo::Bar https://github.com/ruby/ruby/blob/trunk/test/ruby/test_autoload.rb#L336
   end
 
   def test_no_leak
-    skip "This sometimes fails with -DMJIT_FORCE_ENABLE. To be investigated." if RubyVM::MJIT.enabled?
     assert_no_memory_leak([], '', <<~'end;', 'many autoloads', timeout: 30)
       200000.times do |i|
         m = Module.new
Index: test/rubygems/test_gem_util.rb
===================================================================
--- test/rubygems/test_gem_util.rb	(revision 65284)
+++ test/rubygems/test_gem_util.rb	(revision 65285)
@@ -5,7 +5,6 @@ require 'rubygems/util' https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_util.rb#L5
 class TestGemUtil < Gem::TestCase
 
   def test_class_popen
-    skip "MJIT executes process and it's caught by Process.wait(-1)" if defined?(RubyVM::MJIT) && RubyVM::MJIT.enabled?
     assert_equal "0\n", Gem::Util.popen(Gem.ruby, '-e', 'p 0')
 
     assert_raises Errno::ECHILD do
Index: test/-ext-/thread_fd_close/test_thread_fd_close.rb
===================================================================
--- test/-ext-/thread_fd_close/test_thread_fd_close.rb	(revision 65284)
+++ test/-ext-/thread_fd_close/test_thread_fd_close.rb	(revision 65285)
@@ -6,8 +6,6 @@ require 'io/wait' https://github.com/ruby/ruby/blob/trunk/test/-ext-/thread_fd_close/test_thread_fd_close.rb#L6
 class TestThreadFdClose < Test::Unit::TestCase
 
   def test_thread_fd_close
-    skip "MJIT thread is unexpected for this" if RubyVM::MJIT.enabled?
-
     IO.pipe do |r, w|
       th = Thread.new do
         begin

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]