[前][次][番号順一覧][スレッド一覧]

ruby-changes:52149

From: normal <ko1@a...>
Date: Tue, 14 Aug 2018 15:49:31 +0900 (JST)
Subject: [ruby-changes:52149] normal:r64357 (trunk): thread_pthread.c: use UBF_TIMER_PTHREAD on Solaris

normal	2018-08-14 15:49:25 +0900 (Tue, 14 Aug 2018)

  New Revision: 64357

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=64357

  Log:
    thread_pthread.c: use UBF_TIMER_PTHREAD on Solaris
    
    I'm not sure what's causing this failure in Solaris and only
    on rubyspec, since rb_io_wait_readable is a well-exercised
    code path in other places.  But maybe using a pthread for
    timing (similar to old timer-thread) can solve the issue.
    
    cf. http://rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20180814T042506Z.fail.html.gz

  Modified files:
    trunk/thread_pthread.c
Index: thread_pthread.c
===================================================================
--- thread_pthread.c	(revision 64356)
+++ thread_pthread.c	(revision 64357)
@@ -55,7 +55,12 @@ https://github.com/ruby/ruby/blob/trunk/thread_pthread.c#L55
 
 #ifndef UBF_TIMER
 #  if defined(HAVE_TIMER_SETTIME) && defined(HAVE_TIMER_CREATE) && \
-      defined(CLOCK_MONOTONIC) && defined(USE_UBF_LIST)
+      defined(CLOCK_MONOTONIC) && defined(USE_UBF_LIST) && \
+      !defined(__sun)
+      /*
+       * XXX somebody with Solaris experience should be able to fix this:
+       * http://rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20180814T042506Z.fail.html.gz
+       */
      /* preferred */
 #    define UBF_TIMER UBF_TIMER_POSIX
 #  elif defined(USE_UBF_LIST)

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]