[前][次][番号順一覧][スレッド一覧]

ruby-changes:51966

From: normal <ko1@a...>
Date: Sat, 4 Aug 2018 06:53:28 +0900 (JST)
Subject: [ruby-changes:51966] normal:r64181 (trunk): spec/ruby/library/socket/socket/getaddrinfo_spec.rb: avoid nonsensical lookup

normal	2018-08-04 06:53:21 +0900 (Sat, 04 Aug 2018)

  New Revision: 64181

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=64181

  Log:
    spec/ruby/library/socket/socket/getaddrinfo_spec.rb: avoid nonsensical lookup
    
    "http" is a TCP service, so /etc/services on typical GNU/Linux systems
    only specify a TCP port for it.  Use "discard" since it seems
    used for other specs and is specified as both TCP and UDP.
    
    This caused many CI failures like the following:
      git clone https://gist.github.com/812a9b747e4c4cb2e844d4be7991cd2d

  Modified files:
    trunk/spec/ruby/library/socket/socket/getaddrinfo_spec.rb
Index: spec/ruby/library/socket/socket/getaddrinfo_spec.rb
===================================================================
--- spec/ruby/library/socket/socket/getaddrinfo_spec.rb	(revision 64180)
+++ spec/ruby/library/socket/socket/getaddrinfo_spec.rb	(revision 64181)
@@ -278,11 +278,11 @@ describe 'Socket.getaddrinfo' do https://github.com/ruby/ruby/blob/trunk/spec/ruby/library/socket/socket/getaddrinfo_spec.rb#L278
 
     platform_is_not :windows do
       it 'accepts a Fixnum as the protocol family' do
-        addr = Socket.getaddrinfo(nil, 'http', :INET, :DGRAM, Socket::IPPROTO_UDP)
+        addr = Socket.getaddrinfo(nil, 'discard', :INET, :DGRAM, Socket::IPPROTO_UDP)
 
         addr[0].should == [
           'AF_INET',
-          80,
+          9,
           '127.0.0.1',
           '127.0.0.1',
           Socket::AF_INET,

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]