ruby-changes:51172
From: k0kubun <ko1@a...>
Date: Wed, 9 May 2018 22:09:10 +0900 (JST)
Subject: [ruby-changes:51172] k0kubun:r63379 (trunk): _mjit_compile_pc_and_sp.erb: revert r63360
k0kubun 2018-05-09 22:09:01 +0900 (Wed, 09 May 2018) New Revision: 63379 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=63379 Log: _mjit_compile_pc_and_sp.erb: revert r63360 Revert "_mjit_compile_pc_and_sp.erb: make sure no uninitialized" This triggered some `NoMethodError`s which seem to be caused by the commit like: https://travis-ci.org/k0kubun/mjit-test/builds/376416934 I'll add tests and fix it later... Modified files: trunk/tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb Index: tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb =================================================================== --- tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb (revision 63378) +++ tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb (revision 63379) @@ -20,11 +20,12 @@ https://github.com/ruby/ruby/blob/trunk/tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb#L20 % # sp motion is optimized away for `handles_frame? #=> false` case. % # Thus sp should be set properly before `goto cancel`. % if insn.handles_frame? + fprintf(f, " reg_cfp->sp = (VALUE *)reg_cfp->bp + stack_size + 1 - <%= insn.pops.size %>;\n"); /* POPN(INSN_ATTR(popn)); */ +% % # JIT-only behavior (pushing JIT's local variables to VM's stack): { rb_snum_t i, push_size; push_size = -<%= insn.call_attribute('sp_inc') %> + <%= insn.rets.size %> - <%= insn.pops.size %>; - fprintf(f, " reg_cfp->sp = (VALUE *)reg_cfp->bp + %ld + 1;\n", push_size); /* POPN(INSN_ATTR(popn)); */ for (i = 0; i < push_size; i++) { /* TODO: use memcpy? */ fprintf(f, " *(reg_cfp->sp + %ld) = stack[%ld];\n", i - push_size, (rb_snum_t)b->stack_size - push_size + i); } -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/