ruby-changes:50707
From: nagachika <ko1@a...>
Date: Thu, 22 Mar 2018 00:04:06 +0900 (JST)
Subject: [ruby-changes:50707] nagachika:r62875 (ruby_2_4): merge revision(s) 62040: [Backport #14388]
nagachika 2018-03-22 00:04:00 +0900 (Thu, 22 Mar 2018) New Revision: 62875 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=62875 Log: merge revision(s) 62040: [Backport #14388] string.c: clear substring code range * string.c (str_substr): substring of broken code range string may be valid or broken. patch by tommy (Masahiro Tomita) at [ruby-dev:50430] [Bug #14388]. Modified directories: branches/ruby_2_4/ Modified files: branches/ruby_2_4/string.c branches/ruby_2_4/test/ruby/test_string.rb branches/ruby_2_4/version.h Index: ruby_2_4/test/ruby/test_string.rb =================================================================== --- ruby_2_4/test/ruby/test_string.rb (revision 62874) +++ ruby_2_4/test/ruby/test_string.rb (revision 62875) @@ -2569,6 +2569,12 @@ CODE https://github.com/ruby/ruby/blob/trunk/ruby_2_4/test/ruby/test_string.rb#L2569 assert_equal("\u3042", "\u3042\u3043".chr) assert_equal('', ''.chr) end + + def test_substr_code_range + data = "\xff" + "a"*200 + assert_not_predicate(data, :valid_encoding?) + assert_predicate(data[100..-1], :valid_encoding?) + end end class TestString2 < TestString Index: ruby_2_4/version.h =================================================================== --- ruby_2_4/version.h (revision 62874) +++ ruby_2_4/version.h (revision 62875) @@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/version.h#L1 #define RUBY_VERSION "2.4.4" #define RUBY_RELEASE_DATE "2018-03-21" -#define RUBY_PATCHLEVEL 278 +#define RUBY_PATCHLEVEL 279 #define RUBY_RELEASE_YEAR 2018 #define RUBY_RELEASE_MONTH 3 Index: ruby_2_4/string.c =================================================================== --- ruby_2_4/string.c (revision 62874) +++ ruby_2_4/string.c (revision 62875) @@ -2451,6 +2451,7 @@ str_substr(VALUE str, long beg, long len https://github.com/ruby/ruby/blob/trunk/ruby_2_4/string.c#L2451 str2 = str_new_shared(rb_obj_class(str2), str2); RSTRING(str2)->as.heap.ptr += ofs; RSTRING(str2)->as.heap.len = len; + ENC_CODERANGE_CLEAR(str2); } else { if (!len && !empty) return Qnil; Index: ruby_2_4 =================================================================== --- ruby_2_4 (revision 62874) +++ ruby_2_4 (revision 62875) Property changes on: ruby_2_4 ___________________________________________________________________ Modified: svn:mergeinfo ## -0,0 +0,1 ## Merged /trunk:r62040 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/