nobu	2018-03-12 15:54:43 +0900 (Mon, 12 Mar 2018)

  New Revision: 62725

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=62725

  Log:
    Fix setting method visibility on method wrapped with prepend
    
    Ignore prepended modules when looking for already defined methods on a
    class to set the visibility on.
    [Fix GH-1834]
    
    From: Dylan Thacker-Smith <Dylan.Smith@s...>

  Modified files:
    trunk/spec/ruby/core/module/private_spec.rb
    trunk/test/ruby/test_module.rb
    trunk/vm_method.c
Index: test/ruby/test_module.rb
===================================================================
--- test/ruby/test_module.rb	(revision 62724)
+++ test/ruby/test_module.rb	(revision 62725)
@@ -1887,6 +1887,25 @@ class TestModule < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_module.rb#L1887
     assert_raise(ArgumentError) { Module.new { prepend } }
   end
 
+  def test_prepend_private_super
+    wrapper = Module.new do
+      def wrapped
+        super + 1
+      end
+    end
+
+    klass = Class.new do
+      prepend wrapper
+
+      def wrapped
+        1
+      end
+      private :wrapped
+    end
+
+    assert_equal(2, klass.new.wrapped)
+  end
+
   def test_class_variables
     m = Module.new
     m.class_variable_set(:@@foo, 1)
Index: vm_method.c
===================================================================
--- vm_method.c	(revision 62724)
+++ vm_method.c	(revision 62725)
@@ -1054,8 +1054,9 @@ rb_export_method(VALUE klass, ID name, r https://github.com/ruby/ruby/blob/trunk/vm_method.c#L1054
 {
     rb_method_entry_t *me;
     VALUE defined_class;
+    VALUE origin_class = RCLASS_ORIGIN(klass);
 
-    me = search_method(klass, name, &defined_class);
+    me = search_method(origin_class, name, &defined_class);
     if (!me && RB_TYPE_P(klass, T_MODULE)) {
 	me = search_method(rb_cObject, name, &defined_class);
     }
@@ -1068,7 +1069,7 @@ rb_export_method(VALUE klass, ID name, r https://github.com/ruby/ruby/blob/trunk/vm_method.c#L1069
     if (METHOD_ENTRY_VISI(me) != visi) {
 	rb_vm_check_redefinition_opt_method(me, klass);
 
-	if (klass == defined_class || RCLASS_ORIGIN(klass) == defined_class) {
+	if (klass == defined_class || origin_class == defined_class) {
 	    METHOD_ENTRY_VISI_SET(me, visi);
 
 	    if (me->def->type == VM_METHOD_TYPE_REFINED && me->def->body.refined.orig_me) {
Index: spec/ruby/core/module/private_spec.rb
===================================================================
--- spec/ruby/core/module/private_spec.rb	(revision 62724)
+++ spec/ruby/core/module/private_spec.rb	(revision 62725)
@@ -51,4 +51,43 @@ describe "Module#private" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/module/private_spec.rb#L51
       Module.new.send(:private, :undefined)
     end.should raise_error(NameError)
   end
+
+  it "only makes the method private in the class it is called on" do
+    base = Class.new do
+      def wrapped
+        1
+      end
+    end
+
+    klass = Class.new(base) do
+      def wrapped
+        super + 1
+      end
+      private :wrapped
+    end
+
+    base.new.wrapped.should == 1
+    lambda do
+      klass.new.wrapped
+    end.should raise_error(NameError)
+  end
+
+  it "continues to allow a prepended module method to call super" do
+    wrapper = Module.new do
+      def wrapped
+        super + 1
+      end
+    end
+
+    klass = Class.new do
+      prepend wrapper
+
+      def wrapped
+        1
+      end
+      private :wrapped
+    end
+
+    klass.new.wrapped.should == 2
+  end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/